Page MenuHomePhabricator

[libunwind][AArch64] Unbreak building with GNU assembler
ClosedPublic

Authored by xry111 on Tue, Mar 14, 9:01 PM.

Details

Summary

GNU assembler mandates armv8.5-a for memtag instructions. Maybe we should remove this restriction in GNU assembler, but let's work around it for current GNU Binutils releases.

Diff Detail

Event Timeline

xry111 created this revision.Tue, Mar 14, 9:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 9:01 PM
xry111 requested review of this revision.Tue, Mar 14, 9:01 PM
nikic added a subscriber: nikic.Thu, Mar 16, 6:35 AM
fmayer accepted this revision.Thu, Mar 16, 2:35 PM
This revision is now accepted and ready to land.Thu, Mar 16, 2:35 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 1:28 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
MaskRay added a comment.EditedSat, Mar 18, 12:32 AM

for current GNU Binutils releases.

It would have been better to include the exact version.