Page MenuHomePhabricator
Differential D146109

[libunwind][AArch64] Unbreak building with GNU assembler
ClosedPublic
Actions

Authored by xry111 on Tue, Mar 14, 9:01 PM.

Details

Reviewers
fmayer
compnerd
MaskRay
Group Reviewers
Restricted Project
Commits
rG5d276380b0b4: [libunwind][AArch64] Unbreak building with GNU assembler
Summary

GNU assembler mandates armv8.5-a for memtag instructions. Maybe we should remove this restriction in GNU assembler, but let's work around it for current GNU Binutils releases.

Diff Detail

Event Timeline

xry111 created this revision.Tue, Mar 14, 9:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptTue, Mar 14, 9:01 PM
Herald added a subscriber: kristof.beyls. · View Herald Transcript
xry111 requested review of this revision.Tue, Mar 14, 9:01 PM
Harbormaster completed remote builds in B219541: Diff 505359.Tue, Mar 14, 10:47 PM
nikic added a subscriber: nikic.Thu, Mar 16, 6:35 AM
fmayer accepted this revision.Thu, Mar 16, 2:35 PM
This revision is now accepted and ready to land.Thu, Mar 16, 2:35 PM
Closed by commit rG5d276380b0b4: [libunwind][AArch64] Unbreak building with GNU assembler (authored by xry111, committed by nikic). · Explain WhyFri, Mar 17, 1:28 AM
This revision was automatically updated to reflect the committed changes.
nikic added a commit: rG5d276380b0b4: [libunwind][AArch64] Unbreak building with GNU assembler.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 1:28 AM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript
Herald added subscribers: libcxx-commits, llvm-commits. · View Herald Transcript
MaskRay added a comment.EditedSat, Mar 18, 12:32 AM

for current GNU Binutils releases.

It would have been better to include the exact version.

Revision Contents
Changeset List

PathSize
libunwind/
src/
3 lines

Diff 506004

View Options

libunwind/src/DwarfInstructions.hpp

Loading...