This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix policy CMP0116 warnings for cmake 3.20 or above.
ClosedPublic

Authored by lntue on Mar 13 2023, 1:16 PM.

Reviewers

michaelrj
sivachandra

Commits

Summary

Warnings due to changes in behavior of cmake 3.20 or above. See
https://cmake.org/cmake/latest/policy/CMP0116.html

Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 13 2023, 1:16 PM

lntue requested review of this revision.Mar 13 2023, 1:16 PM

libc/CMakeLists.txt
7	The approach taken by other LLVM projects is to use the LLVM wide common policy settings. We should copy that approach. For example, look at what clang does: https://github.com/llvm/llvm-project/blob/main/clang/CMakeLists.txt#L3

Include LLVM's cmake policies instead.

lntue marked an inline comment as done.Mar 13 2023, 1:32 PM

This revision is now accepted and ready to land.Mar 13 2023, 1:40 PM

This revision was landed with ongoing or failed builds.Mar 13 2023, 2:28 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

libc/

7 lines

	cmake_minimum_required(VERSION 3.13.4)			cmake_minimum_required(VERSION 3.13.4)

				# Include LLVM's cmake policies.
				if(NOT DEFINED LLVM_COMMON_CMAKE_UTILS)
				set(LLVM_COMMON_CMAKE_UTILS ${CMAKE_CURRENT_SOURCE_DIR}/../cmake)
				endif()
				include(${LLVM_COMMON_CMAKE_UTILS}/Modules/CMakePolicy.cmake
				sivachandraUnsubmitted Done Reply Inline Actions The approach taken by other LLVM projects is to use the LLVM wide common policy settings. We should copy that approach. For example, look at what clang does: https://github.com/llvm/llvm-project/blob/main/clang/CMakeLists.txt#L3 sivachandra: The approach taken by other LLVM projects is to use the LLVM wide common policy settings. We…
				NO_POLICY_SCOPE)

	# Default to C++17			# Default to C++17
	set(CMAKE_CXX_STANDARD 17)			set(CMAKE_CXX_STANDARD 17)

	list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")			list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules")

	# The top-level sourse and binary directories.			# The top-level sourse and binary directories.
	set(LIBC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})			set(LIBC_SOURCE_DIR ${CMAKE_CURRENT_SOURCE_DIR})
	set(LIBC_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})			set(LIBC_BINARY_DIR ${CMAKE_CURRENT_BINARY_DIR})
	▲ Show 20 Lines • Show All 209 Lines • Show Last 20 Lines