This is an archive of the discontinued LLVM Phabricator instance.

[libc] Declare __dso_handle in the integration test instead of startup.
ClosedPublic

Authored by sivachandra on Mar 12 2023, 11:33 PM.

Details

Summary

Fixes #61355. The __dso_handle decl was introduced incorrectly into the startup
objects during the integration test cleanup which moved the integration tests
away from using an artificial sysroot to using -nostdlib. Having it in the
startup creates the duplicate symbol error when one does not use -nostdlib.
Since this is an integration test only problem, it is meaningful to keep it in
the integration test anyway.

Diff Detail

Event Timeline

sivachandra created this revision.Mar 12 2023, 11:33 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 12 2023, 11:33 PM
sivachandra requested review of this revision.Mar 12 2023, 11:33 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2023, 12:47 AM
This revision was automatically updated to reflect the committed changes.

Sorry, I did not intend to push this without review. Because of a mix of branches on my local checkout, I ended up pushing it accidentally.