This is an archive of the discontinued LLVM Phabricator instance.

Differential D145839

WIP: [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB
ClosedPublic

Authored by stephenneuendorffer on Mar 10 2023, 11:55 PM.

Details

Reviewers
gchatelet
sivachandra
lntue
Commits
rG1ab46e5cf86c: [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB
Summary

This library is linked into libc-hdrgen, which is compiled with
DISABLE_LLVM_LINK_LLVM_DYLIB. This option avoids linking with
libLLVM.so when LLVM_LINK_LLVM_DYLIB is specified. Unfortunately,
this can cause wierd linkage errors where symbols are defined
multiple times, with one definition coming from static linkage
and another definition coming from libLLVM.so. This is usually
apparent as a link error with options defined multiple times.

This patch adds DISABLE_LLVM_LINK_LLVM_DYLIB to this library, to
get consistent linkage of libc-hdrgen.

Diff Detail

Event Timeline

stephenneuendorffer created this revision.Mar 10 2023, 11:55 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 10 2023, 11:55 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
stephenneuendorffer requested review of this revision.Mar 10 2023, 11:55 PM
stephenneuendorffer added reviewers: gchatelet, sivachandra, lntue.Mar 10 2023, 11:59 PM
sivachandra accepted this revision.Mar 11 2023, 12:02 AM
This revision is now accepted and ready to land.Mar 11 2023, 12:02 AM
Harbormaster completed remote builds in B218812: Diff 504343.Mar 11 2023, 12:03 AM
lntue accepted this revision.Mar 11 2023, 7:36 AM
Closed by commit rG1ab46e5cf86c: [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB (authored by stephenneuendorffer). · Explain WhyMar 11 2023, 9:16 AM
This revision was automatically updated to reflect the committed changes.
stephenneuendorffer added a commit: rG1ab46e5cf86c: [libc] update LibcTableGenUtil for LLVM_LINK_LLVM_DYLIB.

Revision Contents

PathSize
libc/
utils/
LibcTableGenUtil/
1 line

Diff 504379

libc/utils/LibcTableGenUtil/CMakeLists.txt

add_llvm_library( add_llvm_library(
LibcTableGenUtil LibcTableGenUtil
APIIndexer.cpp APIIndexer.cpp
APIIndexer.h APIIndexer.h
DISABLE_LLVM_LINK_LLVM_DYLIB
LINK_COMPONENTS Support TableGen LINK_COMPONENTS Support TableGen
) )
target_include_directories(LibcTableGenUtil PUBLIC ${LIBC_SOURCE_DIR}) target_include_directories(LibcTableGenUtil PUBLIC ${LIBC_SOURCE_DIR})