This is an archive of the discontinued LLVM Phabricator instance.

In D145812#4185398, @vitalybuka wrote:

It does NOT reproduce without bb01b9919fdd3d5f1b5d78dcb2aa502588618369 :(
However it should trigger UBSAN report on earlier stage of https://lab.llvm.org/buildbot/#/builders/238/builds/1810

Because it's UB we cannot assume that it will compile into a different, incorrect, executable :)

LGTM, thanks!

llvm/test/Transforms/ConstraintElimination/shl.ll
1279	Maybe just name this `shl_55` or something, as this shouldn't overflow. Also might be good to replace `0` with `1` here, as `uge 0` is trivially true.

This revision is now accepted and ready to land.Mar 10 2023, 10:17 AM

use 1

another 1

This revision was landed with ongoing or failed builds.Mar 10 2023, 10:25 AM

Closed by commit rG2cf632a3f39a: [ConstraintElimination] UB reproducer for D145677 (authored by vitalybuka). · Explain Why

This revision was automatically updated to reflect the committed changes.

vitalybuka added a commit: rG2cf632a3f39a: [ConstraintElimination] UB reproducer for D145677.

Harbormaster completed remote builds in B218722: Diff 504209.Mar 10 2023, 1:26 PM

Revision Contents

Path

Size

llvm/

test/

Transforms/

ConstraintElimination/

shl.ll

13 lines

Diff 504210

llvm/test/Transforms/ConstraintElimination/shl.ll

	Show First 20 Lines • Show All 1,269 Lines • ▼ Show 20 Lines
	; CHECK-NEXT: [[SHL_CMP:%.*]] = icmp uge i256 [[SHL_UB]], 0			; CHECK-NEXT: [[SHL_CMP:%.*]] = icmp uge i256 [[SHL_UB]], 0
	; CHECK-NEXT: ret i1 [[SHL_CMP]]			; CHECK-NEXT: ret i1 [[SHL_CMP]]
	;			;
	entry:			entry:
	%shl.ub = shl nuw nsw i256 0, 65			%shl.ub = shl nuw nsw i256 0, 65
	%shl.cmp = icmp uge i256 %shl.ub, 0			%shl.cmp = icmp uge i256 %shl.ub, 0
	ret i1 %shl.cmp			ret i1 %shl.cmp
	}			}

				define i1 @shl_55() {
				fhahnUnsubmitted Done Reply Inline Actions Maybe just name this `shl_55` or something, as this shouldn't overflow. Also might be good to replace `0` with `1` here, as `uge 0` is trivially true. fhahn: Maybe just name this `shl_55` or something, as this shouldn't overflow. Also might be good to…
				; CHECK-LABEL: @shl_55(
				; CHECK-NEXT: entry:
				; CHECK-NEXT: [[SHL_UB:%.*]] = shl nuw nsw i256 1, 55
				; CHECK-NEXT: [[SHL_CMP:%.*]] = icmp uge i256 [[SHL_UB]], 1
				; CHECK-NEXT: ret i1 true
				;
				entry:
				%shl.ub = shl nuw nsw i256 1, 55
				%shl.cmp = icmp uge i256 %shl.ub, 1
				ret i1 %shl.cmp
				}

This is an archive of the discontinued LLVM Phabricator instance.

[ConstraintElimination] UB reproducer for D145677ClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 504210

llvm/test/Transforms/ConstraintElimination/shl.ll

[ConstraintElimination] UB reproducer for D145677
ClosedPublic