This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Only consider innermost cast for !heapallocsite
ClosedPublic

Authored by nikic on Mar 10 2023, 6:12 AM.

Details

Summary

Without opaque pointers, this code determined !heapallocsite based on the innermost cast of the allocation call. With opaque pointers, the casts no longer generate an instruction, so the outermost cast is used. Add an explicit check for nested casts to prevent this.

Diff Detail

Event Timeline

nikic created this revision.Mar 10 2023, 6:12 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 10 2023, 6:12 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
nikic requested review of this revision.Mar 10 2023, 6:12 AM
rnk accepted this revision.May 8 2023, 4:17 PM
rnk added a reviewer: akhuang.
This revision is now accepted and ready to land.May 8 2023, 4:17 PM
akhuang accepted this revision.May 8 2023, 4:21 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptMay 9 2023, 12:50 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript