[clang] Extract ParsedAttrInfo::hasSpelling method (NFC)

[wanders]

Summary

This intends to simplify this checking when it is done in more places.

No functional change intended.

[erichkeane]

Looks like you have a clang-format fix to do (see pre-commit CI), else, LGTM.

[tbaeder]

clang/include/clang/Basic/ParsedAttrInfo.h

92

clang/include/clang/Basic/ParsedAttrInfo.h

constexpr ParsedAttrInfo(AttributeCommonInfo::Kind AttrKind, unsigned NumArgs,
         AcceptsExprPack(AcceptsExprPack), IsTargetSpecific(IsTargetSpecific),
         IsType(IsType), IsStmt(IsStmt), IsKnownToGCC(IsKnownToGCC),
         IsSupportedByPragmaAttribute(IsSupportedByPragmaAttribute),
         Spellings(Spellings), ArgNames(ArgNames) {}
 
 public:
   virtual ~ParsedAttrInfo() = default;
 
+  /// Check if this attribute has specified spelling.
+  bool hasSpelling(AttributeCommonInfo::Syntax Syntax, StringRef Name) const {
+    return llvm::any_of(Spellings, [&](const Spelling &S) {
+      return (S.Syntax == Syntax && S.NormalizedFullName == Name);
+    });
+  }
+
   /// Check if this attribute appertains to D, and issue a diagnostic if not.
   virtual bool diagAppertainsToDecl(Sema &S, const ParsedAttr &Attr,
                                     const Decl *D) const {
     return true;
   }
   /// Check if this attribute appertains to St, and issue a diagnostic if not.
   virtual bool diagAppertainsToStmt(Sema &S, const ParsedAttr &Attr,
                                     const Stmt *St) const {

clang/lib/Sema/ParsedAttr.cpp

const ParsedAttrInfo &ParsedAttrInfo::get(const AttributeCommonInfo &A) {
 
   // Search for a ParsedAttrInfo whose name and syntax match.
   std::string FullName = A.getNormalizedFullName();
   AttributeCommonInfo::Syntax SyntaxUsed = A.getSyntax();
   if (SyntaxUsed == AttributeCommonInfo::AS_ContextSensitiveKeyword)
     SyntaxUsed = AttributeCommonInfo::AS_Keyword;
 
   for (auto &Ptr : getAttributePluginInstances())
-    for (auto &S : Ptr->Spellings)
-      if (S.Syntax == SyntaxUsed && S.NormalizedFullName == FullName)
-        return *Ptr;
+    if (Ptr->hasSpelling(SyntaxUsed, FullName))
 
   // If we failed to find a match then return a default ParsedAttrInfo.
   static const ParsedAttrInfo DefaultParsedAttrInfo(
       AttributeCommonInfo::UnknownAttribute);
   return DefaultParsedAttrInfo;
 }
 
 ArrayRef<const ParsedAttrInfo *> ParsedAttrInfo::getAllBuiltin() {