This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove _LIBCPP_CONSTEVAL
ClosedPublic

Authored by ldionne on Mar 9 2023, 9:28 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGc6b12b7c3bc8: [libc++] Remove _LIBCPP_CONSTEVAL
Summary

It was only used in one place, and it seems entirely valid to use
constexpr unconditionally in that location.

Note that a different change was attempted, i.e. using consteval
unconditionally. However, this led to http://llvm.org/PR60709.

Diff Detail

Event Timeline

ldionne created this revision.Mar 9 2023, 9:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 9:28 AM
ldionne requested review of this revision.Mar 9 2023, 9:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 9:28 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Mar 9 2023, 10:13 AM
This revision is now accepted and ready to land.Mar 9 2023, 10:13 AM
This revision was landed with ongoing or failed builds.Mar 10 2023, 6:05 AM
This revision was automatically updated to reflect the committed changes.