This is an archive of the discontinued LLVM Phabricator instance.

[memprof] Update the isRuntime symbolization check.
ClosedPublic

Authored by snehasish on Mar 7 2023, 11:37 AM.

Details

Summary

Update the isRuntime check to only match against known memprof filenames
where interceptors are defined. This avoid issues where the path does
not include the directory based on how the runtime was compiled. Also
update the unittest.

Diff Detail

Event Timeline

snehasish created this revision.Mar 7 2023, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 11:37 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
snehasish requested review of this revision.Mar 7 2023, 11:37 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 7 2023, 11:37 AM
This revision is now accepted and ready to land.Mar 7 2023, 11:55 AM

Failing build on Windows seems to be unrelated:

Failed Tests (1):
  Clangd Unit Tests :: ./ClangdTests.exe/IncludeCleaner/GenerateMissingHeaderDiags
This revision was landed with ongoing or failed builds.Mar 7 2023, 12:16 PM
This revision was automatically updated to reflect the committed changes.