[Flang] Combine `set_*Kind` functions with Macro

[klausler]

The code is perfectly clear as is. The macro makes the header file messier without adding any real value.

[sunshaoce]

Thanks for your comment. I will close the revision.

flang/include/flang/Common/default-kinds.h

 class IntrinsicTypeDefaultKinds {
 public:
   IntrinsicTypeDefaultKinds();
   int subscriptIntegerKind() const { return subscriptIntegerKind_; }
   int sizeIntegerKind() const { return sizeIntegerKind_; }
   int doublePrecisionKind() const { return doublePrecisionKind_; }
   int quadPrecisionKind() const { return quadPrecisionKind_; }
 
-  IntrinsicTypeDefaultKinds &set_defaultIntegerKind(int);
-  IntrinsicTypeDefaultKinds &set_subscriptIntegerKind(int);
-  IntrinsicTypeDefaultKinds &set_sizeIntegerKind(int);
-  IntrinsicTypeDefaultKinds &set_defaultRealKind(int);
-  IntrinsicTypeDefaultKinds &set_doublePrecisionKind(int);
-  IntrinsicTypeDefaultKinds &set_quadPrecisionKind(int);
-  IntrinsicTypeDefaultKinds &set_defaultCharacterKind(int);
-  IntrinsicTypeDefaultKinds &set_defaultLogicalKind(int);
+#define SET_DEFAULT_KIND(NAME) \
+  IntrinsicTypeDefaultKinds &set_##NAME##Kind(int k) { \
+    NAME##Kind_ = k; \
+    return *this; \
+  }
+
+  SET_DEFAULT_KIND(defaultInteger);
+  SET_DEFAULT_KIND(subscriptInteger);
+  SET_DEFAULT_KIND(sizeInteger);
+  SET_DEFAULT_KIND(defaultReal);
+  SET_DEFAULT_KIND(doublePrecision);
+  SET_DEFAULT_KIND(quadPrecision);
+  SET_DEFAULT_KIND(defaultCharacter);
+  SET_DEFAULT_KIND(defaultLogical);
 
   int GetDefaultKind(TypeCategory) const;
 
 private:
   // Default REAL just simply has to be IEEE-754 single precision today.
   // It occupies one numeric storage unit by definition.  The default INTEGER
   // and default LOGICAL intrinsic types also have to occupy one numeric
   // storage unit, so their kinds are also forced.  Default COMPLEX must always

flang/lib/Common/default-kinds.cpp

 namespace Fortran::common {
 
 IntrinsicTypeDefaultKinds::IntrinsicTypeDefaultKinds() {
 #if __x86_64__
   quadPrecisionKind_ = 10;
 #endif
 }
 
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_defaultIntegerKind(
-    int k) {
-  defaultIntegerKind_ = k;
-  return *this;
-}
-
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_subscriptIntegerKind(
-    int k) {
-  subscriptIntegerKind_ = k;
-  return *this;
-}
-
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_sizeIntegerKind(
-    int k) {
-  sizeIntegerKind_ = k;
-  return *this;
-}
-
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_defaultRealKind(
-    int k) {
-  defaultRealKind_ = k;
-  return *this;
-}
-
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_doublePrecisionKind(
-    int k) {
-  doublePrecisionKind_ = k;
-  return *this;
-}
-
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_quadPrecisionKind(
-    int k) {
-  quadPrecisionKind_ = k;
-  return *this;
-}
-
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_defaultCharacterKind(
-    int k) {
-  defaultCharacterKind_ = k;
-  return *this;
-}
-
-IntrinsicTypeDefaultKinds &IntrinsicTypeDefaultKinds::set_defaultLogicalKind(
-    int k) {
-  defaultLogicalKind_ = k;
-  return *this;
-}
-
 int IntrinsicTypeDefaultKinds::GetDefaultKind(TypeCategory category) const {
   switch (category) {
   case TypeCategory::Integer:
     return defaultIntegerKind_;
   case TypeCategory::Real:
   case TypeCategory::Complex:
     return defaultRealKind_;
   case TypeCategory::Character: