This is an archive of the discontinued LLVM Phabricator instance.

[HIP] Fix regression about `__fp16` args and return value
ClosedPublic

Authored by yaxunl on Mar 5 2023, 6:17 PM.

Details

Summary

HIP allows __fp16 as function arguments and return value by passing
-fallow-half-arguments-and-returns to clang through hipcc.

https://reviews.llvm.org/D133885 removed -fallow-half-arguments-and-returns
and add a TargetInfo member to control it.

This caused regressions in some HIP apps (https://github.com/ROCm-Developer-Tools/HIP/issues/3178).

Diff Detail

Event Timeline

yaxunl created this revision.Mar 5 2023, 6:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 6:17 PM
yaxunl requested review of this revision.Mar 5 2023, 6:17 PM
tra accepted this revision.Mar 6 2023, 10:52 AM
This revision is now accepted and ready to land.Mar 6 2023, 10:52 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptAug 1 2023, 8:29 AM