This is an archive of the discontinued LLVM Phabricator instance.

[InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC
ClosedPublic

Authored by goldstein.w.n on Mar 5 2023, 5:19 PM.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Mar 5 2023, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 5:19 PM
goldstein.w.n requested review of this revision.Mar 5 2023, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 5:19 PM
nikic added a comment.Mar 6 2023, 1:40 AM

Could you please add a negative test with a non-equality predicate? (We should not fold e.g. icmp ult.)

Add negative test

Could you please add a negative test with a non-equality predicate? (We should not fold e.g. icmp ult.)

Done.

nikic accepted this revision.Mar 6 2023, 2:17 PM

LGTM

This revision is now accepted and ready to land.Mar 6 2023, 2:17 PM