Page MenuHomePhabricator
Differential D145338

[InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC
ClosedPublic
Actions

Authored by goldstein.w.n on Sun, Mar 5, 5:19 PM.

Details

Reviewers
nikic
spatel
majnemer
Commits
rGa4bb08eaf4ac: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Sun, Mar 5, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 5, 5:19 PM
goldstein.w.n requested review of this revision.Sun, Mar 5, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptSun, Mar 5, 5:19 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D145339: [InstCombine] Add transform `(icmp eq/ne bitreverse(x), C)` -> `(icmp eq/ne x, bitreverse(C))`.Sun, Mar 5, 5:28 PM
goldstein.w.n added reviewers: nikic, spatel, majnemer.
Herald added a subscriber: StephenFan. · View Herald TranscriptSun, Mar 5, 5:28 PM
Harbormaster completed remote builds in B217466: Diff 502486.Sun, Mar 5, 6:09 PM
Mztea928 added a child revision: D145351: [cmake] Export component info needed to determine which libraries are in libLLVM.so..Sun, Mar 5, 10:16 PM
nikic added a comment.Mon, Mar 6, 1:40 AM

Could you please add a negative test with a non-equality predicate? (We should not fold e.g. icmp ult.)

goldstein.w.n removed a child revision: D145351: [cmake] Export component info needed to determine which libraries are in libLLVM.so..Mon, Mar 6, 10:24 AM
goldstein.w.n updated this revision to Diff 502704.Mon, Mar 6, 10:30 AM

Add negative test

goldstein.w.n added a comment.Mon, Mar 6, 10:30 AM
In D145338#4170793, @nikic wrote:

Could you please add a negative test with a non-equality predicate? (We should not fold e.g. icmp ult.)

Done.

Harbormaster completed remote builds in B217624: Diff 502704.Mon, Mar 6, 1:55 PM
nikic accepted this revision.Mon, Mar 6, 2:17 PM

LGTM

This revision is now accepted and ready to land.Mon, Mar 6, 2:17 PM
Closed by commit rGa4bb08eaf4ac: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC (authored by goldstein.w.n). · Explain WhyMon, Mar 6, 6:31 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGa4bb08eaf4ac: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC.

Revision Contents
Changeset List

PathSize
llvm/
test/
Transforms/
InstCombine/
47 lines

Diff 502886

View Options

llvm/test/Transforms/InstCombine/cmp-intrinsic.ll

Loading...