This is an archive of the discontinued LLVM Phabricator instance.

Differential D145338

[InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC
ClosedPublic

Authored by goldstein.w.n on Mar 5 2023, 5:19 PM.

Details

Reviewers
nikic
spatel
majnemer
Commits
rGa4bb08eaf4ac: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC

Diff Detail

Event Timeline

goldstein.w.n created this revision.Mar 5 2023, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 5:19 PM
goldstein.w.n requested review of this revision.Mar 5 2023, 5:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 5:19 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
goldstein.w.n added a child revision: D145339: [InstCombine] Add transform `(icmp eq/ne bitreverse(x), C)` -> `(icmp eq/ne x, bitreverse(C))`.Mar 5 2023, 5:28 PM
goldstein.w.n added reviewers: nikic, spatel, majnemer.
Herald added a subscriber: StephenFan. · View Herald TranscriptMar 5 2023, 5:28 PM
Harbormaster completed remote builds in B217466: Diff 502486.Mar 5 2023, 6:09 PM
Mztea928 added a child revision: D145351: [cmake] Export component info needed to determine which libraries are in libLLVM.so..Mar 5 2023, 10:16 PM
nikic added a comment.Mar 6 2023, 1:40 AM

Could you please add a negative test with a non-equality predicate? (We should not fold e.g. icmp ult.)

goldstein.w.n removed a child revision: D145351: [cmake] Export component info needed to determine which libraries are in libLLVM.so..Mar 6 2023, 10:24 AM
goldstein.w.n updated this revision to Diff 502704.Mar 6 2023, 10:30 AM

Add negative test

goldstein.w.n added a comment.Mar 6 2023, 10:30 AM
In D145338#4170793, @nikic wrote:

Could you please add a negative test with a non-equality predicate? (We should not fold e.g. icmp ult.)

Done.

Harbormaster completed remote builds in B217624: Diff 502704.Mar 6 2023, 1:55 PM
nikic accepted this revision.Mar 6 2023, 2:17 PM

LGTM

This revision is now accepted and ready to land.Mar 6 2023, 2:17 PM
Closed by commit rGa4bb08eaf4ac: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC (authored by goldstein.w.n). · Explain WhyMar 6 2023, 6:31 PM
This revision was automatically updated to reflect the committed changes.
goldstein.w.n added a commit: rGa4bb08eaf4ac: [InstCombine] Add tests for `(icmp eq/ne bitreverse(x), C)`; NFC.

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
47 lines

Diff 502886

llvm/test/Transforms/InstCombine/cmp-intrinsic.ll

; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -passes=instcombine -S | FileCheck %s ; RUN: opt < %s -passes=instcombine -S | FileCheck %s
declare i16 @llvm.bswap.i16(i16) declare i16 @llvm.bswap.i16(i16)
declare i32 @llvm.bswap.i32(i32) declare i32 @llvm.bswap.i32(i32)
declare <2 x i64> @llvm.bswap.v2i64(<2 x i64>) declare <2 x i64> @llvm.bswap.v2i64(<2 x i64>)
declare i32 @llvm.cttz.i32(i32, i1) declare i32 @llvm.cttz.i32(i32, i1)
declare i33 @llvm.cttz.i33(i33, i1) declare i33 @llvm.cttz.i33(i33, i1)
declare i32 @llvm.ctlz.i32(i32, i1) declare i32 @llvm.ctlz.i32(i32, i1)
declare i33 @llvm.ctlz.i33(i33, i1) declare i33 @llvm.ctlz.i33(i33, i1)
declare i8 @llvm.ctpop.i8(i8) declare i8 @llvm.ctpop.i8(i8)
declare i11 @llvm.ctpop.i11(i11) declare i11 @llvm.ctpop.i11(i11)
declare <2 x i32> @llvm.cttz.v2i32(<2 x i32>, i1) declare <2 x i32> @llvm.cttz.v2i32(<2 x i32>, i1)
declare <2 x i32> @llvm.ctlz.v2i32(<2 x i32>, i1) declare <2 x i32> @llvm.ctlz.v2i32(<2 x i32>, i1)
declare <2 x i32> @llvm.ctpop.v2i32(<2 x i32>) declare <2 x i32> @llvm.ctpop.v2i32(<2 x i32>)
declare i8 @llvm.bitreverse.i8(i8)
declare <2 x i8> @llvm.bitreverse.v2i8(<2 x i8>)
declare void @use6(i6) declare void @use6(i6)
define i1 @bswap_eq_i16(i16 %x) { define i1 @bswap_eq_i16(i16 %x) {
; CHECK-LABEL: @bswap_eq_i16( ; CHECK-LABEL: @bswap_eq_i16(
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i16 [[X:%.*]], 256 ; CHECK-NEXT: [[CMP:%.*]] = icmp eq i16 [[X:%.*]], 256
; CHECK-NEXT: ret i1 [[CMP]] ; CHECK-NEXT: ret i1 [[CMP]]
; ;
%bs = call i16 @llvm.bswap.i16(i16 %x) %bs = call i16 @llvm.bswap.i16(i16 %x)
▲ Show 20 Lines • Show All 733 Lines • ▼ Show 20 Lines
; CHECK-NEXT: [[CMP:%.*]] = icmp ult i4 [[TRUNC]], 7 ; CHECK-NEXT: [[CMP:%.*]] = icmp ult i4 [[TRUNC]], 7
; CHECK-NEXT: ret i1 [[CMP]] ; CHECK-NEXT: ret i1 [[CMP]]
; ;
%tz = tail call i33 @llvm.cttz.i33(i33 %x, i1 false) %tz = tail call i33 @llvm.cttz.i33(i33 %x, i1 false)
%trunc = trunc i33 %tz to i4 %trunc = trunc i33 %tz to i4
%cmp = icmp ult i4 %trunc, 7 %cmp = icmp ult i4 %trunc, 7
ret i1 %cmp ret i1 %cmp
} }
define i1 @bitreverse_ne_22(i8 %x) {
; CHECK-LABEL: @bitreverse_ne_22(
; CHECK-NEXT: [[Y:%.*]] = call i8 @llvm.bitreverse.i8(i8 [[X:%.*]])
; CHECK-NEXT: [[Z:%.*]] = icmp ne i8 [[Y]], 22
; CHECK-NEXT: ret i1 [[Z]]
;
%y = call i8 @llvm.bitreverse.i8(i8 %x)
%z = icmp ne i8 %y, 22
ret i1 %z
}
define i1 @bitreverse_ult_22_fail_not_equality_pred(i8 %x) {
; CHECK-LABEL: @bitreverse_ult_22_fail_not_equality_pred(
; CHECK-NEXT: [[Y:%.*]] = call i8 @llvm.bitreverse.i8(i8 [[X:%.*]])
; CHECK-NEXT: [[Z:%.*]] = icmp ult i8 [[Y]], 22
; CHECK-NEXT: ret i1 [[Z]]
;
%y = call i8 @llvm.bitreverse.i8(i8 %x)
%z = icmp ult i8 %y, 22
ret i1 %z
}
define <2 x i1> @bitreverse_vec_eq_2_2(<2 x i8> %x) {
; CHECK-LABEL: @bitreverse_vec_eq_2_2(
; CHECK-NEXT: [[Y:%.*]] = call <2 x i8> @llvm.bitreverse.v2i8(<2 x i8> [[X:%.*]])
; CHECK-NEXT: [[Z:%.*]] = icmp eq <2 x i8> [[Y]], <i8 2, i8 2>
; CHECK-NEXT: ret <2 x i1> [[Z]]
;
%y = call <2 x i8> @llvm.bitreverse.v2i8(<2 x i8> %x)
%z = icmp eq <2 x i8> %y, <i8 2, i8 2>
ret <2 x i1> %z
}
define <2 x i1> @bitreverse_vec_eq_1_2_todo_no_splat(<2 x i8> %x) {
; CHECK-LABEL: @bitreverse_vec_eq_1_2_todo_no_splat(
; CHECK-NEXT: [[Y:%.*]] = call <2 x i8> @llvm.bitreverse.v2i8(<2 x i8> [[X:%.*]])
; CHECK-NEXT: [[Z:%.*]] = icmp eq <2 x i8> [[Y]], <i8 1, i8 2>
; CHECK-NEXT: ret <2 x i1> [[Z]]
;
%y = call <2 x i8> @llvm.bitreverse.v2i8(<2 x i8> %x)
%z = icmp eq <2 x i8> %y, <i8 1, i8 2>
ret <2 x i1> %z
}