Add HitCount into Breakpoint statistics

[yinghuitan]

Summary

Turns out breakpoint statistics is missing hitCount.
This patches adds the hitCount field.

lldb/source/Breakpoint/Breakpoint.cpp

for (ModuleSP module_sp : module_list.Modules()) {
         // If the section for this location was deleted, that means it's Module
         // has gone away but somebody forgot to tell us. Let's clean it up
         // here.
         Address section_addr(break_loc_sp->GetAddress());
         if (section_addr.SectionWasDeleted()) {
           locations_with_no_section.Add(break_loc_sp);
           continue;
         }
-          
         if (!break_loc_sp->IsEnabled())
           continue;
-        
         SectionSP section_sp(section_addr.GetSection());
-        
         // If we don't have a Section, that means this location is a raw
         // address that we haven't resolved to a section yet.  So we'll have to
         // look in all the new modules to resolve this location. Otherwise, if
         // it was set in this module, re-resolve it here.
         if (section_sp && section_sp->GetModule() == module_sp) {
           if (!seen)
             seen = true;
 
           if (!break_loc_sp->ResolveBreakpointSite()) {
             LLDB_LOGF(log,
                       "Warning: could not set breakpoint site for "
                       "breakpoint location %d of breakpoint %d.\n",
                       break_loc_sp->GetID(), GetID());
           }
         }
       }
-      
       size_t num_to_delete = locations_with_no_section.GetSize();
-      
       for (size_t i = 0; i < num_to_delete; i++)
         m_locations.RemoveLocation(locations_with_no_section.GetByIndex(i));
 
       if (!seen)
         new_modules.AppendIfNeeded(module_sp);
     }
 
     if (new_modules.GetSize() > 0) {

 }
 
 json::Value Breakpoint::GetStatistics() {
   json::Object bp;
   bp.try_emplace("id", GetID());
   bp.try_emplace("resolveTime", m_resolve_time.get().count());
   bp.try_emplace("numLocations", (int64_t)GetNumLocations());
   bp.try_emplace("numResolvedLocations", (int64_t)GetNumResolvedLocations());
+  bp.try_emplace("hitCount", (int64_t)GetHitCount());
   bp.try_emplace("internal", IsInternal());
   if (!m_kind_description.empty())
     bp.try_emplace("kindDescription", m_kind_description);
   // Put the full structured data for reproducing this breakpoint in a key/value
   // pair named "details". This allows the breakpoint's details to be visible
-  // in the stats in case we need to reproduce a breakpoint that has long 
+  // in the stats in case we need to reproduce a breakpoint that has long
   // resolve times
   StructuredData::ObjectSP bp_data_sp = SerializeToStructuredData();
   if (bp_data_sp) {
     std::string buffer;
     llvm::raw_string_ostream ss(buffer);
     json::OStream json_os(ss);
     bp_data_sp->Serialize(json_os);
     if (auto expected_value = llvm::json::parse(ss.str())) {

lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py

def test_add_commands_by_breakpoint_name(self):
         self.runCmd("command script import --allow-reload ./bktptcmd.py")
 
         self.runCmd("breakpoint command add --python-function bktptcmd.function MyBKPTS")
         for id in bp_ids:
             self.expect("breakpoint command list {0}".format(id),
                         patterns=["bktptcmd.function"])
 
 
-
     def test_breakpoint_delete_disabled(self):
         """Test 'break delete --disabled' works"""
         self.build()
         target = self.createTestTarget()
 
         bp_1 = target.BreakpointCreateByName("main")
         bp_2 = target.BreakpointCreateByName("not_here")
         bp_3 = target.BreakpointCreateByName("main")
def test_breakpoints_auto_source_map_relative(self):
         path = "a/b/c/main.cpp"
         bp = target.BreakpointCreateByLocation(path, 2)
         self.assertTrue(bp.GetNumLocations() > 0,
                 'Couldn\'t resolve breakpoint using full path "%s" in executate "%s" with '
                 'debug info that has relative path with matching suffix' % (path, self.getBuildArtifact("a.out")))
 
         source_map_json = self.get_source_map_json()
         self.assertEquals(len(source_map_json), 0, "source map should not be deduced")
+
+
+    def test_breakpoint_statistics_hitcount(self):
+        """Test breakpoints statistics have hitCount field."""
+        self.build()
+        target = self.createTestTarget()
+
+        lldbutil.run_break_set_by_file_and_line(
+            self, "main.c", self.line, num_expected_locations=1, loc_exact=True)
+
+        stream = lldb.SBStream()
+        res = target.GetStatistics().GetAsJSON(stream)
+        self.assertTrue(res.Success())
+        debug_stats = json.loads(stream.GetData())
+        self.assertEqual('targets' in debug_stats, True,
+                'Make sure the "targets" key in in target.GetStatistics()')
+        target_stats = debug_stats['targets'][0]
+        self.assertNotEqual(target_stats, None)
+
+        breakpoints_stats = target_stats['breakpoints']
+        self.assertNotEqual(breakpoints_stats, None)
+        for breakpoint_stats in breakpoints_stats:
+            self.assertIn("hitCount", breakpoint_stats)