[clang][deps] NFC: Refactor and comment ModuleDeps sorting
ClosedPublic
Actions

Authored by jansvoboda11 on Mar 2 2023, 3:01 PM.

Details

Reviewers

Bigcheese

Commits

rG6b80f00bac6a: [clang][deps] NFC: Refactor and comment ModuleDeps sorting

Summary

I once again stumbled across IndexedModuleID and was confused by the mutable InputIndex field.

This patch adds comments around that piece of code and unifies/simplifies related functions.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jansvoboda11 created this revision.Mar 2 2023, 3:01 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 3:01 PM

Herald added subscribers: ributzka, mgrang. · View Herald Transcript

jansvoboda11 requested review of this revision.Mar 2 2023, 3:01 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 3:01 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B217072: Diff 502005.Mar 2 2023, 4:51 PM

lgtm

This revision is now accepted and ready to land.Apr 20 2023, 2:07 PM

This revision was landed with ongoing or failed builds.Apr 21 2023, 10:56 AM

Closed by commit rG6b80f00bac6a: [clang][deps] NFC: Refactor and comment ModuleDeps sorting (authored by jansvoboda11). · Explain Why

This revision was automatically updated to reflect the committed changes.

jansvoboda11 added a commit: rG6b80f00bac6a: [clang][deps] NFC: Refactor and comment ModuleDeps sorting.

Revision Contents
Changeset List

Path

Size

clang/

include/

clang/

Tooling/

DependencyScanning/

ModuleDepCollector.h

8 lines

tools/

clang-scan-deps/

ClangScanDeps.cpp

48 lines

Diff 515834

View Options

clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h