Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
A general comment: If a function is just using the symbolic error values like EINVAL, it can still include <errno.h> directly. Only those places where the errno is updated/read need to include src/errno/errno.h and depend on libc.src.errno.errno.
libc/src/stdio/CMakeLists.txt | ||
---|---|---|
28 | I think you should add a new dep on libc.src.errno.errno for all of these targets? |
Comment Actions
While we could include <errno.h> from those targets, I think it's easier to read if all of the files include the same target.
Add the dep on libc.src.errno.errno.