This is an archive of the discontinued LLVM Phabricator instance.

Make clang/test/C/C2x/n2934.c compatible with targets that do not support thread_local storage.
ClosedPublic

Authored by fanbo-meng on Mar 2 2023, 6:28 AM.

Download Raw Diff

Details

Reviewers

aaron.ballman
abhina.sreeskantharajan
Kai

Commits

rGbe646ef39298: Make clang/test/C/C2x/n2934.c compatible with targets that do not support…

Summary

Add an optional error check to test case for it to pass on targets that do not support thread_local storage.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

fanbo-meng created this revision.Mar 2 2023, 6:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 6:28 AM

fanbo-meng requested review of this revision.Mar 2 2023, 6:28 AM

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 6:28 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

fanbo-meng edited the summary of this revision. (Show Details)Mar 2 2023, 6:30 AM

fanbo-meng added reviewers: aaron.ballman, abhina.sreeskantharajan, Kai.

LGTM

This revision is now accepted and ready to land.Mar 2 2023, 6:40 AM

Harbormaster completed remote builds in B216963: Diff 501847.Mar 2 2023, 7:35 AM

LGTM!

Closed by commit rGbe646ef39298: Make clang/test/C/C2x/n2934.c compatible with targets that do not support… (authored by fanbo-meng). · Explain WhyMar 2 2023, 8:18 AM

This revision was automatically updated to reflect the committed changes.

fanbo-meng added a commit: rGbe646ef39298: Make clang/test/C/C2x/n2934.c compatible with targets that do not support….

Revision Contents

Path

Size

clang/

test/

C2x/

n2934.c

1 line

Diff 501879

clang/test/C/C2x/n2934.c

	// RUN: %clang_cc1 -ffreestanding -verify=c2x -std=c2x -Wpre-c2x-compat %s			// RUN: %clang_cc1 -ffreestanding -verify=c2x -std=c2x -Wpre-c2x-compat %s
	// RUN: %clang_cc1 -ffreestanding -verify=c17 -std=c17 %s			// RUN: %clang_cc1 -ffreestanding -verify=c17 -std=c17 %s

	/* WG14 N2934: yes			/* WG14 N2934: yes
	* Revise spelling of keywords v7			* Revise spelling of keywords v7
	*/			*/

	thread_local struct alignas(int) S { // c2x-warning {{'alignas' is incompatible with C standards before C2x}} \			thread_local struct alignas(int) S { // c2x-warning {{'alignas' is incompatible with C standards before C2x}} \
	c2x-warning {{'thread_local' is incompatible with C standards before C2x}} \			c2x-warning {{'thread_local' is incompatible with C standards before C2x}} \
				c2x-error 0+ {{thread-local storage is not supported for the current target}} \
	c17-error {{unknown type name 'thread_local'}} \			c17-error {{unknown type name 'thread_local'}} \
	c17-error {{expected identifier or '('}} \			c17-error {{expected identifier or '('}} \
	c17-error {{expected ')'}} \			c17-error {{expected ')'}} \
	c17-note {{to match this '('}}			c17-note {{to match this '('}}
	bool b; // c2x-warning {{'bool' is incompatible with C standards before C2x}}			bool b; // c2x-warning {{'bool' is incompatible with C standards before C2x}}
	} s; // c17-error {{type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int}}			} s; // c17-error {{type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int}}

	static_assert(alignof(struct S) == alignof(int), ""); // c2x-warning {{'static_assert' is incompatible with C standards before C2x}} \			static_assert(alignof(struct S) == alignof(int), ""); // c2x-warning {{'static_assert' is incompatible with C standards before C2x}} \
	Show All 40 Lines