This is an archive of the discontinued LLVM Phabricator instance.

[clang-tidy] use isConvertingConstructor to simplify code
AbandonedPublic

Authored by thyecust on Feb 28 2023, 10:56 PM.

Details

Reviewers
njames93
Group Reviewers
Restricted Project
Summary

isConvertingConstructor() is a better API.

https://google.github.io/styleguide/cppguide.html#Implicit_Conversions:

constructors that are callable with a single argument, must be marked explicit in the class definition.

Diff Detail

Event Timeline

thyecust created this revision.Feb 28 2023, 10:56 PM
Herald added a project: Restricted Project. · View Herald Transcript
thyecust requested review of this revision.Feb 28 2023, 10:56 PM
thyecust updated this revision to Diff 501407.Mar 1 2023, 12:49 AM
thyecust abandoned this revision.Mar 1 2023, 2:51 AM

this change looks meaningless now