This is an archive of the discontinued LLVM Phabricator instance.

[MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS
ClosedPublic

Authored by nitesh.jain on Nov 9 2015, 1:39 AM.

Details

Reviewers
ovyalov
clayborg
Summary

The self.getArchitecture() returns the architecture based on the value of "-A" flag passed to dotest.py script.
There are many possible values for MIPS to this option (like mips32r2, mips32r6, mips64, mips64r2,.... ).
This patch uses re.match("mips",arch) to check if architecture string starts with mips.

Diff Detail

Repository
rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 39668.Nov 9 2015, 1:39 AM
nitesh.jain retitled this revision from to [MIPS][LLDB]Fix TestBreakpointCondition.py for MIPS.
nitesh.jain updated this object.
nitesh.jain added reviewers: clayborg, ovyalov.
nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur and 2 others.
clayborg accepted this revision.Nov 9 2015, 10:09 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Nov 9 2015, 10:09 AM
ovyalov accepted this revision.Nov 9 2015, 6:38 PM
ovyalov edited edge metadata.
slthakur closed this revision.Nov 18 2015, 12:16 AM

Committed in r253444 on behalf of @nitesh.jain