This is an archive of the discontinued LLVM Phabricator instance.

Differential D144573

[z/OS][NFC] Remove obsolete code.
ClosedPublic

Authored by zibi on Feb 22 2023, 10:07 AM.

Details

Reviewers
fanbo-meng
Kai
abhina.sreeskantharajan
phosek
Group Reviewers
Restricted Project
Commits
rGbe4aca6475fe: [z/OS][NFC] Remove obsolete code.
Summary

Remoce obsolete code from libcxxabi/CMakeLists.txt

Diff Detail

Event Timeline

zibi created this revision.Feb 22 2023, 10:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2023, 10:07 AM
zibi requested review of this revision.Feb 22 2023, 10:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 22 2023, 10:07 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
zibi retitled this revision from Remove obsolete code. to [z/OS][NFC] Remove obsolete code..Feb 22 2023, 10:15 AM
zibi added reviewers: fanbo-meng, Kai, abhina.sreeskantharajan.
abhina.sreeskantharajan accepted this revision.Feb 22 2023, 10:21 AM

LGTM

Harbormaster completed remote builds in B215308: Diff 499570.Feb 22 2023, 1:33 PM
zibi added a comment.Feb 24 2023, 11:12 AM

Can I go ahead and land this revision or need to wait for libc++abi group approval?
This is a very small non-functional revision.

Also CI failures are unrelated as well timeouts.

phosek accepted this revision.Feb 24 2023, 12:07 PM
This revision is now accepted and ready to land.Feb 24 2023, 12:07 PM
This revision was landed with ongoing or failed builds.Feb 24 2023, 1:04 PM
Closed by commit rGbe4aca6475fe: [z/OS][NFC] Remove obsolete code. (authored by zibi). · Explain Why
This revision was automatically updated to reflect the committed changes.
zibi added a commit: rGbe4aca6475fe: [z/OS][NFC] Remove obsolete code..

Revision Contents

PathSize
libcxxabi/
4 lines

Diff 500280

libcxxabi/CMakeLists.txt

Show First 20 Lines • Show All 239 Lines • ▼ Show 20 Lines
# Include macros for adding and removing libc++abi flags. # Include macros for adding and removing libc++abi flags.
include(HandleLibcxxabiFlags) include(HandleLibcxxabiFlags)
#=============================================================================== #===============================================================================
# Setup Compiler Flags # Setup Compiler Flags
#=============================================================================== #===============================================================================
# Configure target flags # Configure target flags
if(ZOS)
add_flags_if_supported("-fzos-le-char-mode=ebcdic")
endif()
if (${CMAKE_SYSTEM_NAME} MATCHES "AIX") if (${CMAKE_SYSTEM_NAME} MATCHES "AIX")
add_flags_if_supported("-mdefault-visibility-export-mapping=explicit") add_flags_if_supported("-mdefault-visibility-export-mapping=explicit")
set(CMAKE_AIX_EXPORT_ALL_SYMBOLS OFF) set(CMAKE_AIX_EXPORT_ALL_SYMBOLS OFF)
endif() endif()
add_compile_flags("${LIBCXXABI_ADDITIONAL_COMPILE_FLAGS}") add_compile_flags("${LIBCXXABI_ADDITIONAL_COMPILE_FLAGS}")
add_library_flags("${LIBCXXABI_ADDITIONAL_LIBRARIES}") add_library_flags("${LIBCXXABI_ADDITIONAL_LIBRARIES}")
# Configure compiler. Must happen after setting the target flags. # Configure compiler. Must happen after setting the target flags.
▲ Show 20 Lines • Show All 256 Lines • Show Last 20 Lines