[flang] Preserve useResultSymbolShape_ option when folding array constructor shape

[jeanPerier]

Summary

By default evaluate::GetShape(expr) may return a compiler generated expression
using symbols that are part of function interfaces if there are function
references in "expr".
It is not right to replace an inquiry of "expr" with such compiler
generated expression since the call context would be lost, along with
the meaning of the inquiry expression.
Inquiry folding uses GetContextFreeShape(expr) that sets-up
useResultSymbolShape_ in GetShapeHelper to prevent such bad rewrites. But this did not
work properly with array constructor: GetShapeHelper made a call to
GetShape, ignoring and losing the "useResultSymbolShape_" instruction.

[jeanPerier]

Rebase to include unrelated flang test fix.

flang/include/flang/Evaluate/shape.h

private:
   static Shape CreateShape(int rank, NamedEntity &);
 
   template <typename T>
   MaybeExtentExpr GetArrayConstructorValueExtent(
       const ArrayConstructorValue<T> &value) const {
     return common::visit(
         common::visitors{
             [&](const Expr<T> &x) -> MaybeExtentExpr {
-              if (auto xShape{
-                      context_ ? GetShape(*context_, x) : GetShape(x)}) {
+              if (auto xShape{!useResultSymbolShape_ ? (*this)(x)
+                          : context_                 ? GetShape(*context_, x)
+                                                     : GetShape(x)}) {
                 // Array values in array constructors get linearized.
                 return GetSize(std::move(*xShape));
               } else {
                 return std::nullopt;
               }
             },
             [&](const ImpliedDo<T> &ido) -> MaybeExtentExpr {
               // Don't be heroic and try to figure out triangular implied DO

flang/test/Evaluate/rewrite01.f90

associate(x => a)
     print *, lbound(x, 1, kind=8), ubound(x, 1, kind=8), size(x, 1, kind=8)
   end associate
   associate(x => a+42.)
     !CHECK: PRINT *, 1_8, 11_8, 11_8
     print *, lbound(x, 1, kind=8), ubound(x, 1, kind=8), size(x, 1, kind=8)
   end associate
 end subroutine
 
+!CHECK-LABEL: array_constructor
+subroutine array_constructor()
+  interface
+    function return_allocatable()
+     real, allocatable :: return_allocatable(:)
+    end function
+  end interface
+  !CHECK: PRINT *, size([REAL(4)::return_allocatable(),return_allocatable()])
+  print *, size([return_allocatable(), return_allocatable()])
+end subroutine
+
 end module