This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove <experimental/{algorithm,functional}>
ClosedPublic

Authored by philnik on Feb 21 2023, 5:18 AM.

Details

Summary

The contents of these files have been implemented for at least two releases, so let's remove them according to our policy (https://libcxx.llvm.org/DesignDocs/ExperimentalFeatures.html#id4).

Diff Detail

Event Timeline

philnik created this revision.Feb 21 2023, 5:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 5:19 AM
philnik requested review of this revision.Feb 21 2023, 5:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 5:19 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 499134.Feb 21 2023, 5:52 AM

Try to fix CI

Mordante added inline comments.Feb 21 2023, 9:00 AM
libcxx/include/CMakeLists.txt
798

I wonder whether we announced this removal in our release notes... But at least the actual removal should be in the release notes.

798

Mainly curious, but are there not tests that use the experimental headers?

philnik updated this revision to Diff 499463.Feb 22 2023, 5:47 AM
philnik marked 2 inline comments as done.

Address comments

libcxx/include/CMakeLists.txt
798

There are, I just forgot to remove them.

philnik updated this revision to Diff 499510.Feb 22 2023, 7:51 AM

Remove another test

Mordante accepted this revision.Feb 22 2023, 9:27 AM

LGTM!

libcxx/docs/ReleaseNotes.rst
64
libcxx/include/CMakeLists.txt
798

Thanks!

This revision is now accepted and ready to land.Feb 22 2023, 9:27 AM
This revision was landed with ongoing or failed builds.Feb 24 2023, 5:18 AM
This revision was automatically updated to reflect the committed changes.
libcxx/test/std/experimental/func/func.searchers/func.searchers.default/func.searchers.default.creation/make_default_searcher.pred.pass.cpp