Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
We might want to consider a naming convention to accommodate future cpu-tuning tests - how about tuning-shuffle-unpckpd.ll?
llvm/test/CodeGen/X86/unpckpd-to-faster-alternative.ll | ||
---|---|---|
43 ↗ | (On Diff #499024) | Cleanup? |
Agreed, changed in v2.
llvm/test/CodeGen/X86/unpckpd-to-faster-alternative.ll | ||
---|---|---|
43 ↗ | (On Diff #499024) | What do you mean? Thats the output from /home/noah/programs/opensource/llvm-dev/src/llvm-project/llvm/utils/update_llc_test_checks.py --llc-binary /home/noah/programs/opensource/llvm-dev/src/llvm-project/build/bin/llc /home/noah/programs/opensource/llvm-dev/src/llvm-project/llvm/test/CodeGen/X86/unpckpd-to-faster-alternative.ll What command should I use? |
llvm/test/CodeGen/X86/tuning-shuffle-unpckpd.ll | ||
---|---|---|
47 | These will need to be manually editted out and then the update script called to regenerate |
llvm/test/CodeGen/X86/tuning-shuffle-unpckpd.ll | ||
---|---|---|
47 | Still broken :( |
llvm/test/CodeGen/X86/tuning-shuffle-unpckpd.ll | ||
---|---|---|
47 | Bah sorry, didn't see your comment this morning. Fixed. |
Similar to D144779 - we should probably split the avx512 cases off and add evex-vex testing - whatever we decide we should try to keep to the same style for all these tuning-shuffle-* files.
Also, this should block D144570 and not D144779/D144570 - ideally we're going to want D144570 to be in trunk for a few days before any follow ups to shake out any unexpected regressions to prevent a nasty long chain of reversions, which is why I'm so keen to get accepted patches in early instead of you stacking them all up.
llvm/test/CodeGen/X86/tuning-shuffle-unpckpd.ll | ||
---|---|---|
24 | Drop the 512-bit vector test cases - they should be handled by the -avx512.ll file |
Drop the 512-bit vector test cases - they should be handled by the -avx512.ll file