Page MenuHomePhabricator
Differential D144326

[libc++][format] Addresses LWG3720.
Needs ReviewPublic
Actions

Authored by Mordante on Feb 18 2023, 3:48 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary
LWG3720 Restrict the valid types of arg-id for width and precision in
std-format-spec

Depends on D144325

Diff Detail

Event Timeline

Mordante created this revision.Feb 18 2023, 3:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2023, 3:48 AM
Mordante requested review of this revision.Feb 18 2023, 3:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 18 2023, 3:48 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B214562: Diff 498574.Feb 18 2023, 4:13 AM
Mordante updated this revision to Diff 498576.Feb 18 2023, 4:32 AM

CI fixes.

Mordante updated this revision to Diff 498587.Feb 18 2023, 6:28 AM

CI fixes.

Harbormaster completed remote builds in B214572: Diff 498587.Feb 18 2023, 10:54 AM
Mordante mentioned this in D145127: [libc++][doc] Mark LWG-3720 as "Nothing to do".Thu, Mar 2, 11:05 AM
ldionne added a subscriber: ldionne.Tue, Mar 14, 8:53 AM
ldionne added inline comments.
libcxx/test/std/utilities/format/format.string/format.string.std/lwg3720_arg_id_width_precision_allowed_types.verify.cpp
31

Do we get some sort of note that explains the reason for the format failing to parse?

Mordante marked an inline comment as done.Tue, Mar 14, 10:27 AM
Mordante added inline comments.
libcxx/test/std/utilities/format/format.string/format.string.std/lwg3720_arg_id_width_precision_allowed_types.verify.cpp
31

Unfortunately no. I know it can be done with template magic, but that seems non-trivial to do. I have considered adding a way to get better compile time errors in Clang. There is a recent paper by Barry (P2758) which proposes something like that, but even more powerful than I originally considered.

Mordante mentioned this in D144325: [NFC][libc++][format] Improves diagnostics..Tue, Mar 14, 10:49 AM

Revision Contents
Changeset List

PathSize
libcxx/
docs/
Status/
2 lines
include/
__format/
57 lines
25 lines
test/
std/
utilities/
format/
format.functions/
10 lines
format.range/
format.range.fmtset/
3 lines
3 lines
format.string/
format.string.std/
92 lines
111 lines

Diff 498587

View Options

libcxx/docs/Status/Cxx2bIssues.csv

Loading...
View Options

libcxx/include/__format/format_functions.h

Loading...
View Options

libcxx/include/__format/parser_std_format_spec.h

Loading...
View Options

libcxx/test/std/utilities/format/format.functions/format_tests.h

Loading...
View Options

libcxx/test/std/utilities/format/format.range/format.range.fmtset/format.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/format/format.range/format.range.fmtset/parse.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/format/format.string/format.string.std/lwg3720_arg_id_width_precision_allowed_types.pass.cpp

Loading...
View Options

libcxx/test/std/utilities/format/format.string/format.string.std/lwg3720_arg_id_width_precision_allowed_types.verify.cpp

Loading...