This is an archive of the discontinued LLVM Phabricator instance.

Differential D145127

[libc++][doc] Mark LWG-3720 as "Nothing to do"
AbandonedPublic

Authored by fsb4000 on Mar 1 2023, 3:50 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Summary

https://cplusplus.github.io/LWG/issue3720

Diff Detail

Event Timeline

fsb4000 created this revision.Mar 1 2023, 3:50 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 3:50 PM
fsb4000 requested review of this revision.Mar 1 2023, 3:50 PM
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptMar 1 2023, 3:50 PM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B216852: Diff 501688.Mar 1 2023, 6:17 PM
Mordante added inline comments.Mar 2 2023, 11:05 AM
libcxx/docs/Status/Cxx2bIssues.csv
253

Actually I disagree with this statement, see D144326

fsb4000 added inline comments.Mar 2 2023, 3:07 PM
libcxx/docs/Status/Cxx2bIssues.csv
253

Ok.

I thought __i128 and __u128 are supported as libc++ extension.

fsb4000 abandoned this revision.Mar 2 2023, 3:07 PM
Mordante added inline comments.Mar 3 2023, 8:51 AM
libcxx/docs/Status/Cxx2bIssues.csv
253

They are, but the LWG issue's wording explicitly mentions standard signed or unsigned integer. My original wording didn't contain the word standard, but during LWG review that was added. Therefore I wanted to remove 128-bit support here.

Revision Contents

PathSize
libcxx/
docs/
Status/
2 lines

Diff 501688

libcxx/docs/Status/Cxx2bIssues.csv

Show First 20 Lines • Show All 244 Lines • ▼ Show 20 Lines
"`3824 <https://wg21.link/LWG3824>`__","Number of ``bind`` placeholders is underspecified", "November 2022","|Nothing to do|","","" "`3824 <https://wg21.link/LWG3824>`__","Number of ``bind`` placeholders is underspecified", "November 2022","|Nothing to do|","",""
"`3826 <https://wg21.link/LWG3826>`__","Redundant specification [for overload of yield_value]", "November 2022","","","" "`3826 <https://wg21.link/LWG3826>`__","Redundant specification [for overload of yield_value]", "November 2022","","",""
"","","","","","" "","","","","",""
"`2195 <https://wg21.link/LWG2195>`__","Missing constructors for ``match_results``","February 2023","","","" "`2195 <https://wg21.link/LWG2195>`__","Missing constructors for ``match_results``","February 2023","","",""
"`2295 <https://wg21.link/LWG2295>`__","Locale name when the provided ``Facet`` is a ``nullptr``","February 2023","","","" "`2295 <https://wg21.link/LWG2295>`__","Locale name when the provided ``Facet`` is a ``nullptr``","February 2023","","",""
"`3032 <https://wg21.link/LWG3032>`__","``ValueSwappable`` requirement missing for ``push_heap`` and ``make_heap``","February 2023","","","" "`3032 <https://wg21.link/LWG3032>`__","``ValueSwappable`` requirement missing for ``push_heap`` and ``make_heap``","February 2023","","",""
"`3085 <https://wg21.link/LWG3085>`__","``char_traits::copy`` precondition too weak","February 2023","","","" "`3085 <https://wg21.link/LWG3085>`__","``char_traits::copy`` precondition too weak","February 2023","","",""
"`3664 <https://wg21.link/LWG3664>`__","`LWG 3392 <https://wg21.link/LWG3392>`__ ``broke std::ranges::distance(a, a+3)``","February 2023","","","|ranges|" "`3664 <https://wg21.link/LWG3664>`__","`LWG 3392 <https://wg21.link/LWG3392>`__ ``broke std::ranges::distance(a, a+3)``","February 2023","","","|ranges|"
"`3720 <https://wg21.link/LWG3720>`__","Restrict the valid types of ``arg-id`` for width and precision in ``std-format-spec``","February 2023","","","|format|" "`3720 <https://wg21.link/LWG3720>`__","Restrict the valid types of ``arg-id`` for width and precision in ``std-format-spec``","February 2023","Nothing to do","","|format|"
MordanteUnsubmitted
Not Done
ReplyInline Actions

Actually I disagree with this statement, see D144326

Mordante: Actually I disagree with this statement, see D144326
fsb4000AuthorUnsubmitted
Done
ReplyInline Actions

Ok.

I thought __i128 and __u128 are supported as libc++ extension.

fsb4000: Ok. I thought `__i128` and `__u128` are supported as libc++ extension.
MordanteUnsubmitted
Not Done
ReplyInline Actions

They are, but the LWG issue's wording explicitly mentions standard signed or unsigned integer. My original wording didn't contain the word standard, but during LWG review that was added. Therefore I wanted to remove 128-bit support here.

Mordante: They are, but the LWG issue's wording explicitly mentions `standard signed or unsigned integer`.
"`3756 <https://wg21.link/LWG3756>`__","Is the ``std::atomic_flag`` class signal-safe?","February 2023","","","" "`3756 <https://wg21.link/LWG3756>`__","Is the ``std::atomic_flag`` class signal-safe?","February 2023","","",""
"`3769 <https://wg21.link/LWG3769>`__","``basic_const_iterator::operator==`` causes infinite constraint recursion","February 2023","","","|spaceship|" "`3769 <https://wg21.link/LWG3769>`__","``basic_const_iterator::operator==`` causes infinite constraint recursion","February 2023","","","|spaceship|"
"`3807 <https://wg21.link/LWG3807>`__","The feature test macro for ``ranges::find_last`` should be renamed","February 2023","","","|ranges|" "`3807 <https://wg21.link/LWG3807>`__","The feature test macro for ``ranges::find_last`` should be renamed","February 2023","","","|ranges|"
"`3811 <https://wg21.link/LWG3811>`__","``views::as_const`` on ``ref_view<T>`` should return ``ref_view<const T>``","February 2023","","","|ranges|" "`3811 <https://wg21.link/LWG3811>`__","``views::as_const`` on ``ref_view<T>`` should return ``ref_view<const T>``","February 2023","","","|ranges|"
"`3820 <https://wg21.link/LWG3820>`__","``cartesian_product_view::iterator::prev`` is not quite right","February 2023","","","|ranges|" "`3820 <https://wg21.link/LWG3820>`__","``cartesian_product_view::iterator::prev`` is not quite right","February 2023","","","|ranges|"
"`3825 <https://wg21.link/LWG3825>`__","Missing compile-time argument ``id`` check in ``basic_format_parse_context::next_arg_id``","February 2023","","","|format|" "`3825 <https://wg21.link/LWG3825>`__","Missing compile-time argument ``id`` check in ``basic_format_parse_context::next_arg_id``","February 2023","","","|format|"
"`3204 <https://wg21.link/LWG3204>`__","``sub_match::swap`` only swaps the base class","February 2023","|Complete|","17.0","" "`3204 <https://wg21.link/LWG3204>`__","``sub_match::swap`` only swaps the base class","February 2023","|Complete|","17.0",""
"`3733 <https://wg21.link/LWG3733>`__","``ranges::to`` misuses ``cpp17-input-iterator``","February 2023","","","|ranges|" "`3733 <https://wg21.link/LWG3733>`__","``ranges::to`` misuses ``cpp17-input-iterator``","February 2023","","","|ranges|"
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines