The llvm-readobj prints extra characters for the timestamp when --file-headers is used with an XCOFF file. This change updates the format string used to print the time. In addition, the timestamp is printed in the local timezone, and a thread-safe call is used to convert the time.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/tools/llvm-readobj/XCOFFDumper.cpp | ||
---|---|---|
105 | This is failing to build on Windows. |
Comment Actions
This update backs out the changes except for removing the extra characters. WIthout a Windows system, the changes to use localtime_r() and update the test case are not practical. It would be nice to have a common function to print timestamps for all object file formats.
Comment Actions
LGTMing this, to clear my objection, but I'm not a user of XCOFF, so I'd like one of the developers who regularly works on this to take a look too before this lands.
@Esme/@DiggerLin, any comments from either of you two?
@stephenpeckham, don't forget to update your commit message if you're dropping the localtime_r stuff.
This is failing to build on Windows.