This is an archive of the discontinued LLVM Phabricator instance.

Differential D144140

[libc][bazel] add string to float targets
ClosedPublic

Authored by michaelrj on Feb 15 2023, 2:27 PM.

Details

Reviewers
lntue
sivachandra
Commits
rGdccd1d736c25: [libc][bazel] add string to float targets
Summary

This patch adds atof, strtof, strtod, and strtold to the bazel build, as
well as their tests.

Diff Detail

Event Timeline

michaelrj created this revision.Feb 15 2023, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 2:27 PM
Herald added subscribers: ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Feb 15 2023, 2:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 2:27 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
sivachandra accepted this revision.Feb 15 2023, 2:35 PM
This revision is now accepted and ready to land.Feb 15 2023, 2:35 PM
Harbormaster completed remote builds in B213993: Diff 497805.Feb 15 2023, 2:41 PM
This revision was landed with ongoing or failed builds.Feb 16 2023, 11:22 AM
Closed by commit rGdccd1d736c25: [libc][bazel] add string to float targets (authored by michaelrj). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGdccd1d736c25: [libc][bazel] add string to float targets.

Revision Contents

PathSize
utils/
bazel/
llvm-project-overlay/
libc/
58 lines
test/
src/
stdlib/
45 lines

Diff 498103

utils/bazel/llvm-project-overlay/libc/BUILD.bazel

Show First 20 Lines • Show All 286 Lines • ▼ Show 20 Lines deps = [
":__support_common", ":__support_common",
":__support_cpp_limits", ":__support_cpp_limits",
":__support_ctype_utils", ":__support_ctype_utils",
":__support_str_to_num_result", ":__support_str_to_num_result",
], ],
) )
libc_support_library( libc_support_library(
name = "__support_str_to_float",
hdrs = [
"src/__support/detailed_powers_of_ten.h",
"src/__support/high_precision_decimal.h",
"src/__support/str_to_float.h",
],
deps = [
":__support_builtin_wrappers",
":__support_common",
":__support_cpp_limits",
":__support_ctype_utils",
":__support_fputil_fp_bits",
":__support_str_to_integer",
":__support_uint128",
],
)
libc_support_library(
name = "__support_fputil_basic_operations", name = "__support_fputil_basic_operations",
hdrs = ["src/__support/FPUtil/BasicOperations.h"], hdrs = ["src/__support/FPUtil/BasicOperations.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_cpp_type_traits", ":__support_cpp_type_traits",
":__support_fputil_fp_bits", ":__support_fputil_fp_bits",
":libc_root", ":libc_root",
], ],
▲ Show 20 Lines • Show All 1,016 Lines • ▼ Show 20 Lineslibc_function(
hdrs = ["src/stdlib/atoll.h"], hdrs = ["src/stdlib/atoll.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_str_to_integer", ":__support_str_to_integer",
], ],
) )
libc_function( libc_function(
name = "atof",
srcs = ["src/stdlib/atof.cpp"],
hdrs = ["src/stdlib/atof.h"],
deps = [
":__support_common",
":__support_str_to_float",
],
)
libc_function(
name = "bsearch", name = "bsearch",
srcs = ["src/stdlib/bsearch.cpp"], srcs = ["src/stdlib/bsearch.cpp"],
hdrs = ["src/stdlib/bsearch.h"], hdrs = ["src/stdlib/bsearch.h"],
deps = [ deps = [
":__support_common", ":__support_common",
], ],
) )
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lineslibc_function(
srcs = ["src/stdlib/strtoull.cpp"], srcs = ["src/stdlib/strtoull.cpp"],
hdrs = ["src/stdlib/strtoull.h"], hdrs = ["src/stdlib/strtoull.h"],
deps = [ deps = [
":__support_common", ":__support_common",
":__support_str_to_integer", ":__support_str_to_integer",
], ],
) )
libc_function(
name = "strtof",
srcs = ["src/stdlib/strtof.cpp"],
hdrs = ["src/stdlib/strtof.h"],
deps = [
":__support_common",
":__support_str_to_float",
],
)
libc_function(
name = "strtod",
srcs = ["src/stdlib/strtod.cpp"],
hdrs = ["src/stdlib/strtod.h"],
deps = [
":__support_common",
":__support_str_to_float",
],
)
libc_function(
name = "strtold",
srcs = ["src/stdlib/strtold.cpp"],
hdrs = ["src/stdlib/strtold.h"],
deps = [
":__support_common",
":__support_str_to_float",
],
)
############################### string targets ############################### ############################### string targets ###############################
no_sanitize_features = [ no_sanitize_features = [
"-asan", "-asan",
"-msan", "-msan",
"-tsan", "-tsan",
"-ubsan", "-ubsan",
] ]
▲ Show 20 Lines • Show All 475 Lines • Show Last 20 Lines

utils/bazel/llvm-project-overlay/libc/test/src/stdlib/BUILD.bazel

Show All 40 Lineslibc_test(
srcs = ["atoll_test.cpp"], srcs = ["atoll_test.cpp"],
deps = [":atoi_test_helper"], deps = [":atoi_test_helper"],
libc_function_deps = [ libc_function_deps = [
"//libc:atoll", "//libc:atoll",
], ],
) )
libc_test( libc_test(
name = "atof_test",
srcs = ["atof_test.cpp"],
deps = ["//libc:__support_fputil_fp_bits"],
libc_function_deps = [
"//libc:atof",
],
)
libc_test(
name = "bsearch_test", name = "bsearch_test",
srcs = ["bsearch_test.cpp"], srcs = ["bsearch_test.cpp"],
libc_function_deps = [ libc_function_deps = [
"//libc:bsearch", "//libc:bsearch",
], ],
) )
libc_test( libc_test(
▲ Show 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
libc_test( libc_test(
name = "strtoull_test", name = "strtoull_test",
srcs = ["strtoull_test.cpp"], srcs = ["strtoull_test.cpp"],
deps = [":strtol_test_helper"], deps = [":strtol_test_helper"],
libc_function_deps = [ libc_function_deps = [
"//libc:strtoull", "//libc:strtoull",
], ],
) )
libc_test(
name = "strtof_test",
srcs = ["strtof_test.cpp"],
deps = [
"//libc:__support_fputil_fp_bits",
"//libc/utils/testutils:libc_test_utils",
],
libc_function_deps = [
"//libc:strtof",
],
)
libc_test(
name = "strtod_test",
srcs = ["strtod_test.cpp"],
deps = [
"//libc:__support_fputil_fp_bits",
"//libc/utils/testutils:libc_test_utils",
],
libc_function_deps = [
"//libc:strtod",
],
)
libc_test(
name = "strtold_test",
srcs = ["strtold_test.cpp"],
deps = [
"//libc:__support_fputil_fp_bits",
"//libc:__support_uint128",
],
libc_function_deps = [
"//libc:strtold",
],
)