This is an archive of the discontinued LLVM Phabricator instance.

[HLSL] add log library functions
ClosedPublic

Authored by bob80905 on Feb 15 2023, 10:23 AM.

Details

Summary

This change exposes the log library functions for HLSL,excluding long, int, and long long doubles. The log functions are supported for all scalar, vector, and matrix types.
Long and long long double support is missing in this patch because those types
don't exist in HLSL. Int is missing because the log functions only work on floating type arguments.

The full documentation of the HLSL log functions are available here:
https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-log
https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-log2
https://docs.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-log10

Diff Detail

Event Timeline

bob80905 created this revision.Feb 15 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 10:23 AM
Herald added a subscriber: Anastasia. · View Herald Transcript
bob80905 requested review of this revision.Feb 15 2023, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 10:23 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
bob80905 retitled this revision from [HLSL] add log library functions This change exposes the log library functions for HLSL, excluding long, int, and long long doubles. The log functions are supported for all scalar, vector, and matrix types. Long and long long double support is... to [HLSL] add log library functionsThis change exposes the log library functions for HLSL,excluding long, int, and long long doubles.The log functions are supported for all scalar, vector, and matrix types.Long and long long double support is....Feb 15 2023, 10:25 AM
bob80905 added reviewers: python3kgae, beanz.
bob80905 retitled this revision from [HLSL] add log library functionsThis change exposes the log library functions for HLSL,excluding long, int, and long long doubles.The log functions are supported for all scalar, vector, and matrix types.Long and long long double support is... to [HLSL] add log library functions.
bob80905 edited the summary of this revision. (Show Details)
python3kgae accepted this revision.Feb 15 2023, 6:48 PM

LGTM.
Just fix the newline at end of file for the tests.

This revision is now accepted and ready to land.Feb 15 2023, 6:48 PM
bob80905 updated this revision to Diff 498051.Feb 16 2023, 9:27 AM
  • add newline
This revision was landed with ongoing or failed builds.Feb 16 2023, 9:51 AM
This revision was automatically updated to reflect the committed changes.