This is an archive of the discontinued LLVM Phabricator instance.

Differential D143701

[NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax
ClosedPublic

Authored by thieta on Feb 9 2023, 11:35 PM.

Details

Reviewers
MaskRay
browneee
Commits
rG57edc61093d9: [NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax
Summary

I found a few Python files not using Python 3 syntax in the tree
when trying to apply reformatting to them. This was converted with
2to3 and the changes seemed sane.

Diff Detail

Event Timeline

thieta created this revision.Feb 9 2023, 11:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2023, 11:35 PM
Herald added subscribers: Enna1, dberris. · View Herald Transcript
thieta requested review of this revision.Feb 9 2023, 11:35 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 9 2023, 11:35 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
MaskRay accepted this revision.Feb 9 2023, 11:48 PM
This revision is now accepted and ready to land.Feb 9 2023, 11:48 PM
MaskRay added a subscriber: browneee.Feb 9 2023, 11:48 PM
Harbormaster completed remote builds in B212958: Diff 496341.Feb 10 2023, 12:20 AM
browneee accepted this revision.Feb 10 2023, 1:04 AM
Closed by commit rG57edc61093d9: [NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax (authored by thieta). · Explain WhyFeb 10 2023, 1:21 AM
This revision was automatically updated to reflect the committed changes.
thieta added a commit: rG57edc61093d9: [NFC] convert compiler-rt/lib/dfsan/scripts/build-libc-list.py to python3 syntax.
MaskRay mentioned this in rG35188e02d1f2: [dfsan] Fix build-libc-list.py for Python 3 after D143701.Feb 10 2023, 10:56 AM

Revision Contents

PathSize
compiler-rt/
lib/
dfsan/
scripts/
8 lines

Diff 496369

compiler-rt/lib/dfsan/scripts/build-libc-list.py

Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines
p.add_option('--error-missing-lib', action='store_true', p.add_option('--error-missing-lib', action='store_true',
help='Make this script exit with an error code if any library is missing.', help='Make this script exit with an error code if any library is missing.',
dest='error_missing_lib', default=False) dest='error_missing_lib', default=False)
(options, args) = p.parse_args() (options, args) = p.parse_args()
libs = options.lib_file libs = options.lib_file
if not libs: if not libs:
print >> sys.stderr, 'No libraries provided.' print('No libraries provided.', file=sys.stderr)
exit(1) exit(1)
missing_lib = False missing_lib = False
functions = [] functions = []
for l in libs: for l in libs:
if os.path.exists(l): if os.path.exists(l):
functions += defined_function_list(l) functions += defined_function_list(l)
else: else:
missing_lib = True missing_lib = True
print >> sys.stderr, 'warning: library %s not found' % l print('warning: library %s not found' % l, file=sys.stderr)
if options.error_missing_lib and missing_lib: if options.error_missing_lib and missing_lib:
print >> sys.stderr, 'Exiting with failure code due to missing library.' print('Exiting with failure code due to missing library.', file=sys.stderr)
exit(1) exit(1)
functions = list(set(functions)) functions = list(set(functions))
functions.sort() functions.sort()
for f in functions: for f in functions:
print 'fun:%s=uninstrumented' % f print('fun:%s=uninstrumented' % f)