AddLLVM: squelch CMP0007 by not adding empty elements to list

[artagnon]

Summary

When configuring various llvm projects that use AddLLVM.cmake, this warning is
emitted many times, flooding the screen:

Policy CMP0007 is not set: list command no longer ignores empty elements.

The fix is removing an extra semicolon.

[beanz]

LGTM. Make sure not to remove the newline at the end of the file, your uploaded diff did.

[artagnon]

It's actually an extra newline character that my editor automatically stripped out. *nix has the requirement that all lines must end with a newline character, not that a file must end with an empty line.

Nothing I care about either way; just saying.

cmake/modules/AddLLVM.cmake

if (NOT uppercase_CMAKE_BUILD_TYPE STREQUAL "DEBUG")
     endif()
   endif()
 endfunction(add_link_opts)
 
 # Set each output directory according to ${CMAKE_CONFIGURATION_TYPES}.
 # Note: Don't set variables CMAKE_*_OUTPUT_DIRECTORY any more,
 # or a certain builder, for eaxample, msbuild.exe, would be confused.
 function(set_output_directory target)
-  cmake_parse_arguments(ARG "" "BINARY_DIR;LIBRARY_DIR;" "" ${ARGN})
+  cmake_parse_arguments(ARG "" "BINARY_DIR;LIBRARY_DIR" "" ${ARGN})
 
   # module_dir -- corresponding to LIBRARY_OUTPUT_DIRECTORY.
   # It affects output of add_library(MODULE).
   if(WIN32 OR CYGWIN)
     # DLL platform
     set(module_dir ${ARG_BINARY_DIR})
   else()
     set(module_dir ${ARG_LIBRARY_DIR})

 function(llvm_install_symlink name dest)
   cmake_parse_arguments(ARG "ALWAYS_GENERATE" "" "" ${ARGN})
   foreach(path ${CMAKE_MODULE_PATH})
     if(EXISTS ${path}/LLVMInstallSymlink.cmake)
       set(INSTALL_SYMLINK ${path}/LLVMInstallSymlink.cmake)
       break()
     endif()
   endforeach()
-  
   if(ARG_ALWAYS_GENERATE)
     set(component ${dest})
   else()
     set(component ${name})
   endif()
 
   set(full_name ${name}${CMAKE_EXECUTABLE_SUFFIX})
   set(full_dest ${dest}${CMAKE_EXECUTABLE_SUFFIX})
else()
     # tool and its parent tool are in LLVM_TOOLCHAIN_TOOLS
     if (LLVM_IS_${name}_TOOLCHAIN_TOOL GREATER -1 OR NOT LLVM_INSTALL_TOOLCHAIN_ONLY)
       if( LLVM_BUILD_TOOLS )
         llvm_install_symlink(${name} ${dest})
       endif()
     endif()
   endif()
 endfunction()
-