This is an archive of the discontinued LLVM Phabricator instance.

AddLLVM: squelch CMP0007 by not adding empty elements to list
ClosedPublic

Authored by artagnon on Nov 4 2015, 10:55 AM.

Details

Summary

When configuring various llvm projects that use AddLLVM.cmake, this warning is
emitted many times, flooding the screen:

Policy CMP0007 is not set: list command no longer ignores empty elements.

The fix is removing an extra semicolon.

Diff Detail

Event Timeline

artagnon updated this revision to Diff 39218.Nov 4 2015, 10:55 AM
artagnon retitled this revision from to AddLLVM: squelch CMP0007 by not adding empty elements to list.
artagnon updated this object.
artagnon added reviewers: chapuni, beanz, rnk.
artagnon added a subscriber: llvm-commits.
beanz accepted this revision.Nov 4 2015, 10:57 AM
beanz edited edge metadata.

LGTM. Make sure not to remove the newline at the end of the file, your uploaded diff did.

This revision is now accepted and ready to land.Nov 4 2015, 10:57 AM

It's actually an extra newline character that my editor automatically stripped out. *nix has the requirement that all lines must end with a newline character, not that a file must end with an empty line.

Nothing I care about either way; just saying.

This revision was automatically updated to reflect the committed changes.