Depends on D142808
Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rG2f2ed477143e: [libc++][test] Removes rapid-cxx-test.h.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
LGTM, thanks! This is a nice cleanup since it makes all of our tests use the same conventions.
libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/file_size.pass.cpp | ||
---|---|---|
108 | You're missing an include of assert_macros.h here. | |
libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/hard_link_count.pass.cpp | ||
171 | Same here, and probably elsewhere. |
Comment Actions
Thanks for the review.
libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/file_size.pass.cpp | ||
---|---|---|
108 | Agreed, the tests still worked due to filesystem_test_helper.h including this file. | |
libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/hard_link_count.pass.cpp | ||
171 | I had that already done locally. Due to the changes in the parent patch I've given the patch another CI run to make sure everything still works. |
You're missing an include of assert_macros.h here.