This is an archive of the discontinued LLVM Phabricator instance.

[libc++][test] Removes rapid-cxx-test.h.
ClosedPublic

Authored by Mordante on Feb 6 2023, 4:24 AM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG2f2ed477143e: [libc++][test] Removes rapid-cxx-test.h.
Summary

Depends on D142808

Diff Detail

Event Timeline

Mordante created this revision.Feb 6 2023, 4:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 4:24 AM
Herald added a subscriber: jdoerfert. · View Herald Transcript
Mordante requested review of this revision.Feb 6 2023, 4:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2023, 4:24 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 14 2023, 9:55 AM
ldionne added a subscriber: ldionne.

LGTM, thanks! This is a nice cleanup since it makes all of our tests use the same conventions.

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/file_size.pass.cpp
109

You're missing an include of assert_macros.h here.

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/hard_link_count.pass.cpp
172

Same here, and probably elsewhere.

This revision is now accepted and ready to land.Feb 14 2023, 9:55 AM
Mordante updated this revision to Diff 498385.Feb 17 2023, 8:14 AM

Rebased and addresses review comments.

Mordante marked 2 inline comments as done.Feb 17 2023, 8:59 AM

Thanks for the review.

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/file_size.pass.cpp
109

Agreed, the tests still worked due to filesystem_test_helper.h including this file.

libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.obs/hard_link_count.pass.cpp
172

I had that already done locally.

Due to the changes in the parent patch I've given the patch another CI run to make sure everything still works.

Mordante updated this revision to Diff 498422.Feb 17 2023, 9:54 AM
Mordante marked 2 inline comments as done.

CI fixes.

Mordante updated this revision to Diff 498467.Feb 17 2023, 11:42 AM

Avoid std::forward to avoid including the utility header.

This revision was automatically updated to reflect the committed changes.
libcxx/test/support/filesystem_test_helper.h