This is an archive of the discontinued LLVM Phabricator instance.

Differential D143348

[Clang][Doc][OpenCL] Release 16 notes
ClosedPublic

Authored by Anastasia on Feb 5 2023, 12:58 PM.

Details

Reviewers
svenvh
tstellar
Summary

Documented major OpenCL features in release 16.

Diff Detail

Event Timeline

Anastasia created this revision.Feb 5 2023, 12:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 5 2023, 12:58 PM
Herald added subscribers: Naghasan, ebevhan, yaxunl. · View Herald Transcript
Anastasia requested review of this revision.Feb 5 2023, 12:58 PM
Harbormaster completed remote builds in B211955: Diff 494945.Feb 5 2023, 2:42 PM
tstellar accepted this revision.Feb 6 2023, 8:29 AM

LGTM.

This revision is now accepted and ready to land.Feb 6 2023, 8:29 AM
svenvh added inline comments.Feb 6 2023, 9:09 AM
clang/docs/ReleaseNotes.rst
840

It's slightly more than that: clang adds nounwind not only for builtin functions, but for any OpenCL function call.

Anastasia updated this revision to Diff 496790.Feb 12 2023, 1:28 PM

Updated bullet about nounwind attr

Anastasia added inline comments.Feb 12 2023, 1:30 PM
clang/docs/ReleaseNotes.rst
840

Thanks, this makes sense... stack unwind in OpenCL kernel is meaningless atm.

However has this change been made in a separate commit?

Harbormaster completed remote builds in B213300: Diff 496790.Feb 12 2023, 2:36 PM
svenvh accepted this revision.Feb 13 2023, 1:49 AM
svenvh added inline comments.
clang/docs/ReleaseNotes.rst
840

The change of https://reviews.llvm.org/D142033 is not specific to builtins.

Please remember to decrease the indent level of this bullet point, so that it is no longer under "Improved builtin functions support". Otherwise LGTM.

Anastasia closed this revision.Feb 19 2023, 1:47 PM

Committed in https://github.com/llvm/llvm-project/commit/639db8a90d2adf7789b9d3cec3a7c26502bf819b

Revision Contents

PathSize
clang/
docs/
11 lines

Diff 496790

clang/docs/ReleaseNotes.rst

Context not available.
Objective-C Language Changes in Clang Objective-C Language Changes in Clang
------------------------------------- -------------------------------------
OpenCL C Language Changes in Clang OpenCL Kernel Language Changes in Clang
---------------------------------- ----------------------------------
... - Improved diagnostics for C++ templates used in kernel arguments.
- Removed redundant pragma for the ``arm-integer-dot-product`` extension.
- Improved support of enqueued block for AMDGPU.
- Improved builtin functions support:
* Allow disabling default header-based feature/extension support by passing ``-D__undef_<feature>``.
* Fixed conditional definition of the depth image and read_write image3d builtins.
* Added ``nounwind`` attribute implicitly to all functions.
svenvhUnsubmitted
Not Done
ReplyInline Actions

It's slightly more than that: clang adds nounwind not only for builtin functions, but for any OpenCL function call.

svenvh: It's slightly more than that: clang adds `nounwind` not only for builtin functions, but for any…
AnastasiaAuthorUnsubmitted
Done
ReplyInline Actions

Thanks, this makes sense... stack unwind in OpenCL kernel is meaningless atm.

However has this change been made in a separate commit?

Anastasia: Thanks, this makes sense... stack unwind in OpenCL kernel is meaningless atm. However has this…
svenvhUnsubmitted
Not Done
ReplyInline Actions

The change of https://reviews.llvm.org/D142033 is not specific to builtins.

Please remember to decrease the indent level of this bullet point, so that it is no longer under "Improved builtin functions support". Otherwise LGTM.

svenvh: The change of https://reviews.llvm.org/D142033 is not specific to builtins. Please remember to…
ABI Changes in Clang ABI Changes in Clang
-------------------- --------------------
Context not available.