Details
- Reviewers
ldionne Mordante var-const - Group Reviewers
Restricted Project Restricted Project - Commits
- rGe8cb3559eec0: [libc++] Move constexpr <cstring> functions into their own headers and remove…
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
LGTM, modulo the naming of the file.
libcxx/include/__string/constexpr_c_functions.h | ||
---|---|---|
11 | I would name the file constexpr_c_functions.h, these are all private functions and not C functions, so the current name is slightly misleading. | |
libcxx/test/libcxx/transitive_includes/cxx20.csv | ||
341 | Since <format> isn't stable yet, I agree this is fine. |
libcxx/include/__string/constexpr_c_functions.h | ||
---|---|---|
11 | I'm a bit confused. I guess you would like a different name, but your suggestion is identical to the current name. Did you forget to replace the name? |
LGTM, please make sure Mark didn't have another name in mind. I personally am fine with this name or any other reasonable name.
libcxx/include/__string/constexpr_c_functions.h | ||
---|---|---|
11 |
Copy-paste error ;-) I would name the file constexpr_functions.h, these are all private functions and not C functions, so the current name is slightly misleading. |
libcxx/include/__string/constexpr_c_functions.h | ||
---|---|---|
11 | I see your point, but I think constexpr_functions.h is very open. If you just read the name you would ask "What functions?". Although I admit that you could also read constexpr_c_functions.h as "all the C functions that are constexpr", I think it's closer to a good name. In case anybody has other suggestions we can still rename the file later. |
I would name the file constexpr_c_functions.h, these are all private functions and not C functions, so the current name is slightly misleading.