This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Disable default config files for tests
ClosedPublic

Authored by thesamesam on Feb 4 2023, 8:19 AM.

Details

Summary

Without this, if hardening measures like FORTIFY_SOURCE are are in
/etc/clang/*.cfg, many sanitizer tests will die before the sanitizer
can trap the problem being tested, because e.g. the _chk variants
of common functions will abort first.

This gets the number of failing tests down from 42->3 for me (and the
remaining 3 are unrelated).

See: 52ce6776cf98e993c6ec04ae54b52e1354fff917
See: 136f77805fd89cd30e69b3d1204fbf7efedd9a12
Closes: https://github.com/llvm/llvm-project/issues/60394

Diff Detail

Event Timeline

thesamesam created this revision.Feb 4 2023, 8:19 AM
thesamesam requested review of this revision.Feb 4 2023, 8:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 4 2023, 8:19 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
thesamesam updated this revision to Diff 494834.Feb 4 2023, 8:35 AM

Hoist into lit.common.cfg.py per mgorny's suggestion.

MaskRay accepted this revision.Feb 4 2023, 9:56 AM

Thanks!

compiler-rt/test/lit.common.cfg.py
741 ↗(On Diff #494834)

_FORTIFY_SOURCE

This revision is now accepted and ready to land.Feb 4 2023, 9:56 AM
This revision was landed with ongoing or failed builds.Feb 4 2023, 10:04 AM
This revision was automatically updated to reflect the committed changes.