[Release] Increase test-release.sh verbosity

[ro]

Summary

test-release.sh is too silent in some cases:

• Only the build proper is run verbosely, but check-all is not.
• lit is run without -v, so in case of failures one cannot see what's actually wrong.

This patch fixes both issues, running all ${MAKE} invocations with $Verbose (except for ${MAKE} install where it would only add noise), and running lit with -v.

Tested on x86_64-pc-linux-gnu and arm64-apple-darwin21.6.

Btw., I just noticed that one may want to also echo the ${MAKE} check-all and ${MAKE} check calls for symmetry.

[ro]

I forgot: this is certainly something that should go onto the release/16.x branch ASAP.

[tstellar]

LGTM, Thanks, can you open the backport request for release/16.x ?

[ro]

In D143249#4103303, @tstellar wrote:

LGTM, Thanks, can you open the backport request for release/16.x ?

Sure, done as Issue #60553.

llvm/utils/release/test-release.sh

function configure_llvmCore() {
     cd $ObjDir
     echo "# Configuring llvm $Release-$RC $Flavor"
 
     echo "#" env CC="$c_compiler" CXX="$cxx_compiler" \
         cmake -G "$generator" \
         -DCMAKE_BUILD_TYPE=$BuildType -DLLVM_ENABLE_ASSERTIONS=$Assertions \
         -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
         -DLLVM_ENABLE_PROJECTS="$project_list" \
-        -DLLVM_LIT_ARGS="-j $NumJobs" \
+        -DLLVM_LIT_ARGS="-j $NumJobs $LitVerbose" \
         -DLLVM_ENABLE_RUNTIMES="$runtime_list" \
         $ExtraConfigureFlags $BuildDir/llvm-project/llvm \
         2>&1 | tee $LogDir/llvm.configure-Phase$Phase-$Flavor.log
     env CC="$c_compiler" CXX="$cxx_compiler" \
         cmake -G "$generator" \
         -DCMAKE_BUILD_TYPE=$BuildType -DLLVM_ENABLE_ASSERTIONS=$Assertions \
         -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
         -DLLVM_ENABLE_PROJECTS="$project_list" \
-        -DLLVM_LIT_ARGS="-j $NumJobs" \
+        -DLLVM_LIT_ARGS="-j $NumJobs $LitVerbose" \
         -DLLVM_ENABLE_RUNTIMES="$runtime_list" \
         $ExtraConfigureFlags $BuildDir/llvm-project/llvm \
         2>&1 | tee $LogDir/llvm.configure-Phase$Phase-$Flavor.log
 
     cd $BuildDir
 }
 
 function build_llvmCore() {
     Phase="$1"
     Flavor="$2"
     ObjDir="$3"
     DestDir="$4"
 
     Verbose="VERBOSE=1"
     if [ ${MAKE} = 'ninja' ]; then
       Verbose="-v"
     fi
+    LitVerbose="-v"
 
     redir="/dev/stdout"
     if [ $do_silent_log == "yes" ]; then
       echo "# Silencing build logs because of -silent-log flag..."
       redir="/dev/null"
     fi
 
     cd $ObjDir
function test_llvmCore() {
     KeepGoing="-k"
     if [ ${MAKE} = 'ninja' ]; then
       # Ninja doesn't have a documented "keep-going-forever" mode, we need to
       # set a limit on how many jobs can fail before we give up.
       KeepGoing="-k 100"
     fi
 
     cd $ObjDir
-    if ! ( ${MAKE} -j $NumJobs $KeepGoing check-all \
+    if ! ( ${MAKE} -j $NumJobs $KeepGoing $Verbose check-all \
         2>&1 | tee $LogDir/llvm.check-Phase$Phase-$Flavor.log ) ; then
       deferred_error $Phase $Flavor "check-all failed"
     fi
 
     if [ $do_test_suite = 'yes' ]; then
       cd $TestSuiteBuildDir
       env CC="$c_compiler" CXX="$cxx_compiler" \
           cmake $TestSuiteSrcDir -G "$generator" -DTEST_SUITE_LIT=$Lit \
                 -DTEST_SUITE_HOST_CC=$build_compiler
 
-      if ! ( ${MAKE} -j $NumJobs $KeepGoing check \
+      if ! ( ${MAKE} -j $NumJobs $KeepGoing $Verbose check \
           2>&1 | tee $LogDir/llvm.check-Phase$Phase-$Flavor.log ) ; then
         deferred_error $Phase $Flavor "test suite failed"
       fi
     fi
     cd $BuildDir
 }
 
 # Clean RPATH. Libtool adds the build directory to the search path, which is