This is an archive of the discontinued LLVM Phabricator instance.

[libc] Remove a now uneccesary CMake policy.
ClosedPublic

Authored by sivachandra on Feb 1 2023, 11:26 PM.

Diff Detail

Event Timeline

sivachandra created this revision.Feb 1 2023, 11:26 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 1 2023, 11:26 PM
sivachandra requested review of this revision.Feb 1 2023, 11:26 PM
jhuber6 accepted this revision.Feb 2 2023, 4:42 AM
This revision is now accepted and ready to land.Feb 2 2023, 4:42 AM

+1

Any chance we could get the rest of LLVM upgraded to 3.20.0 as well? I'd like to get Ninja Multi-Config working.

+1

Any chance we could get the rest of LLVM upgraded to 3.20.0 as well? I'd like to get Ninja Multi-Config working.

CMake Warning at CMakeLists.txt:5 (message):

Your CMake version is 3.18.4.  Starting with LLVM 17.0.0, the minimum
version of CMake required to build LLVM will become 3.20.0, and using an
older CMake will become an error.  Please upgrade your CMake to at least
3.20.0 now to avoid issues in the future!

Seems the buildbots need to be updated first.

CMake Warning at CMakeLists.txt:5 (message):

Your CMake version is 3.18.4.  Starting with LLVM 17.0.0, the minimum
version of CMake required to build LLVM will become 3.20.0, and using an
older CMake will become an error.  Please upgrade your CMake to at least
3.20.0 now to avoid issues in the future!

Seems the buildbots need to be updated first.

For us, the buildbot builders are the indicators of health. Should we have to block on these pre-commit failures?

Remove the CMake version bump as it is being done in
https://reviews.llvm.org/D144509 in a single-shot to
the entire llvm-project.

sivachandra retitled this revision from [libc] Bump minimum CMake version to 3.20.0 and remove a now uneccesary policy. to [libc] Remove a now uneccesary CMake policy..Feb 23 2023, 7:00 PM
sivachandra edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Feb 23 2023, 7:03 PM
This revision was automatically updated to reflect the committed changes.