This is an archive of the discontinued LLVM Phabricator instance.

[libc][math] Fix setting exceptional value for tanf to work with gcc.
ClosedPublic

Authored by lntue on Feb 1 2023, 11:27 AM.

Diff Detail

Event Timeline

lntue created this revision.Feb 1 2023, 11:27 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 1 2023, 11:27 AM
lntue requested review of this revision.Feb 1 2023, 11:27 AM
sivachandra added inline comments.Feb 1 2023, 11:33 AM
libc/src/math/generic/tanf.cpp
100–105

Can you add some commentary to explain why a volatile is required?

lntue updated this revision to Diff 494027.Feb 1 2023, 11:52 AM

Add comments.

lntue marked an inline comment as done.Feb 1 2023, 11:53 AM
sivachandra accepted this revision.Feb 1 2023, 12:27 PM
This revision is now accepted and ready to land.Feb 1 2023, 12:27 PM