Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks!
The changes in C++ mapping are good in general. Most removals are reasonable, my only concern is the removal of std::{begin, end, size, empty, data} (as they are now provided by multiple headers), IMO these are important symbols (no action needed in this patch, I added them back manually as part of the c-compatibility header change https://reviews.llvm.org/D143160).
clang/include/clang/Tooling/Inclusions/CSymbolMap.inc | ||
---|---|---|
12 ↗ | (On Diff #493873) | We're removing many macros, macros seems to be moved out to a separated page (https://en.cppreference.com/w/c/symbol_index/macro) in the latest cppreference snapshot, there are some more work needed to update this file. Let's postpone it and focus on the C++ symbols in this patch. |
Thanks, it looks good.
One remaining suggestion is to merge the StdRemovedSymbolMap.inc to the StdSymbolMap.inc (it doesn't seem to add much value to maintain a separate file for zoombie symbols), I will address it and land the patch for you.