This is an archive of the discontinued LLVM Phabricator instance.

[include-mapping] Regenerate the mappings from the 20220730 html book.
ClosedPublic

Authored by VitaNuo on Feb 1 2023, 1:40 AM.

Diff Detail

Event Timeline

VitaNuo created this revision.Feb 1 2023, 1:40 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 1 2023, 1:40 AM
VitaNuo requested review of this revision.Feb 1 2023, 1:40 AM
Herald added a project: Restricted Project. · View Herald Transcript
VitaNuo edited reviewers, added: hokein; removed: jdoerfert.Feb 1 2023, 1:41 AM
hokein added a comment.Feb 2 2023, 3:20 AM

Thanks!

The changes in C++ mapping are good in general. Most removals are reasonable, my only concern is the removal of std::{begin, end, size, empty, data} (as they are now provided by multiple headers), IMO these are important symbols (no action needed in this patch, I added them back manually as part of the c-compatibility header change https://reviews.llvm.org/D143160).

clang/include/clang/Tooling/Inclusions/CSymbolMap.inc
12 ↗(On Diff #493873)

We're removing many macros, macros seems to be moved out to a separated page (https://en.cppreference.com/w/c/symbol_index/macro) in the latest cppreference snapshot, there are some more work needed to update this file. Let's postpone it and focus on the C++ symbols in this patch.

VitaNuo updated this revision to Diff 494250.Feb 2 2023, 4:05 AM

Remove the C symbol map from commit.

Sure, removed the C symbol mapping from this patch. Thanks.

hokein added a comment.Feb 6 2023, 6:38 AM

Thanks, it looks good.

One remaining suggestion is to merge the StdRemovedSymbolMap.inc to the StdSymbolMap.inc (it doesn't seem to add much value to maintain a separate file for zoombie symbols), I will address it and land the patch for you.

hokein updated this revision to Diff 495108.Feb 6 2023, 6:42 AM

merge zoombie names to StdSymboMap.inc

This revision was not accepted when it landed; it landed in state Needs Review.Feb 7 2023, 5:52 AM
This revision was automatically updated to reflect the committed changes.