This is an archive of the discontinued LLVM Phabricator instance.

[docs] Rewrite/improve the docs for LLVM_NATIVE_TOOL_DIR
ClosedPublic

Authored by mstorsjo on Jan 31 2023, 1:14 AM.

Details

Summary

Don't include it among the mandatory options; the automatically built
tools via a nested cmake build work fine these days
(in particular, since 93010544a813dfbfa64dd7cee68785f572f974d1 /
https://reviews.llvm.org/D126313).

Clarify the directory path-to-host-bin into something more verbose,
to avoid ambiguity with LLVM_HOST_TRIPLE.

This goes on top of D142404.

Diff Detail

Event Timeline

mstorsjo created this revision.Jan 31 2023, 1:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 1:14 AM
mstorsjo requested review of this revision.Jan 31 2023, 1:14 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2023, 1:14 AM

No objections, if the option isn't needed then we should remove it from the mandatory part.

phosek accepted this revision.Jan 31 2023, 11:47 PM

LGTM

This revision is now accepted and ready to land.Jan 31 2023, 11:47 PM
This revision was landed with ongoing or failed builds.Feb 3 2023, 12:57 AM
This revision was automatically updated to reflect the committed changes.