Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[libcxx] Make it possible to build a no-exceptions variant of libcxx.

Authored by rmaprath on Nov 3 2015, 10:13 AM.



Fixes a small omission in libcxx that prevents libcxx being built when -DLIBCXX_ENABLE_EXCEPTIONS=0 is used.

I will do a follow-up patch to introduce the new libc++ build to the buildbot.

Diff Detail

Event Timeline

rmaprath updated this revision to Diff 39082.Nov 3 2015, 10:13 AM
rmaprath retitled this revision from to [libcxx] Make it possible to build a no-exceptions variant of libcxx..
rmaprath updated this object.
rmaprath added reviewers: rengolin, mclow.lists.
rmaprath added a subscriber: cfe-commits.
rmaprath updated this revision to Diff 39541.Nov 6 2015, 8:33 AM

Patch updated to add XFAILS for all those tests that are failing on the new (-fno-exceptions) library variant. Follow-up patches will progressively un-XFAIL these tests (i.e. adapt them to cope with the new library variant).

jroelofs accepted this revision.Nov 9 2015, 7:24 AM
jroelofs edited edge metadata.


This revision is now accepted and ready to land.Nov 9 2015, 7:24 AM
rmaprath closed this revision.Nov 10 2015, 4:59 AM

Thanks Jon!

Committed as r252598. The current buildbots are happy (except for the ARM one, which seem to have gone away).

I will update D14293 to include the new runs.


  • Asiri