This is an archive of the discontinued LLVM Phabricator instance.

[ValueTracking] Add cases for additional ops in `isKnownNonZero`
ClosedPublic

Authored by goldstein.w.n on Jan 28 2023, 8:58 PM.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Jan 28 2023, 8:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 8:58 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
goldstein.w.n requested review of this revision.Jan 28 2023, 8:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2023, 8:58 PM
nikic accepted this revision.Jan 29 2023, 12:39 AM

LGTM

llvm/lib/Analysis/ValueTracking.cpp
2760–2779

Invoke handling unnecessary

llvm/test/Analysis/ValueTracking/known-non-zero.ll
53–54

Not really relevant in InstSimplify?

This revision is now accepted and ready to land.Jan 29 2023, 12:39 AM
goldstein.w.n marked 2 inline comments as done.Jan 29 2023, 1:20 PM
goldstein.w.n added inline comments.
llvm/lib/Analysis/ValueTracking.cpp
2760–2779

Invoke handling unnecessary

Dropped, sorry was just copying from computeKnowBits.

llvm/test/Analysis/ValueTracking/known-non-zero.ll
53–54

Not really relevant in InstSimplify?

Good point. Dropped from D142827 (and likewise this).

goldstein.w.n marked 2 inline comments as done.

Remove invoke/ rebase

This revision was landed with ongoing or failed builds.Feb 18 2023, 11:45 AM
This revision was automatically updated to reflect the committed changes.