This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Implement MUL[_S].PH, MULEQ_S.W.PHL, MULEQ_S.W.PHR, MULEU_S.PH.QBL, MULEU_S.PH.QBR, MULQ_RS.PH, MULQ_RS.W, MULQ_S.PH and MULQ_S.W instructions
ClosedPublic

Authored by hvarga on Nov 3 2015, 3:59 AM.

Details

Summary

The patch implements microMIPSDSP instructions: MUL[_S].PH, MULEQ_S.W.PHL, MULEQ_S.W.PHR, MULEU_S.PH.QBL, MULEU_S.PH.QBR, MULQ_RS.PH, MULQ_RS.W, MULQ_S.PH, MULQ_S.W.

Diff Detail

Event Timeline

hvarga updated this revision to Diff 39043.Nov 3 2015, 3:59 AM
hvarga retitled this revision from to [mips][microMIPS] Implement MUL[_S].PH, MULEQ_S.W.PHL, MULEQ_S.W.PHR, MULEU_S.PH.QBL, MULEU_S.PH.QBR, MULQ_RS.PH, MULQ_RS.W, MULQ_S.PH and MULQ_S.W instructions.
hvarga updated this object.
hvarga added subscribers: petarj, llvm-commits.
dsanders accepted this revision.Nov 14 2015, 6:12 AM
dsanders edited edge metadata.

LGTM with a small test change

lib/Target/Mips/MicroMipsDSPInstrInfo.td
69

Formatting nit: Bring back the space after '//' and the '.'

test/MC/Disassembler/Mips/micromips-dspr2/valid.txt
18–22

The DSPr1 tests should also be present. Likewise for the assembler tests.

See my comment on D14058 for more info.

This revision is now accepted and ready to land.Nov 14 2015, 6:12 AM
This revision was automatically updated to reflect the committed changes.

Standard encoding tests will be a separate task.