This is an archive of the discontinued LLVM Phabricator instance.

Differential D142788

[libc] Use a more general way to determine the compiler's target triple.
ClosedPublic

Authored by sivachandra on Jan 27 2023, 4:16 PM.

Details

Reviewers
lntue
michaelrj
Commits
rG12b65a66fc20: [libc] Use a more general way to determine the compiler's target triple.

Diff Detail

Event Timeline

sivachandra created this revision.Jan 27 2023, 4:16 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptJan 27 2023, 4:16 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
sivachandra requested review of this revision.Jan 27 2023, 4:16 PM
sivachandra retitled this revision from [libc] Use a move general way to determine the compiler's target triple. to [libc] Use a more general way to determine the compiler's target triple..Jan 27 2023, 4:17 PM
Harbormaster completed remote builds in B210495: Diff 492943.Jan 27 2023, 4:22 PM
lntue accepted this revision.Jan 30 2023, 7:40 AM
This revision is now accepted and ready to land.Jan 30 2023, 7:40 AM
Closed by commit rG12b65a66fc20: [libc] Use a more general way to determine the compiler's target triple. (authored by sivachandra). · Explain WhyJan 30 2023, 8:34 AM
This revision was automatically updated to reflect the committed changes.
sivachandra added a commit: rG12b65a66fc20: [libc] Use a more general way to determine the compiler's target triple..

Revision Contents

PathSize
libc/
cmake/
modules/
26 lines

Diff 493322

libc/cmake/modules/LLVMLibCArchitectures.cmake

Show First 20 Lines • Show All 68 Lines • ▼ Show 20 Linesfunction(get_arch_and_system_from_triple triple arch_var sys_var)
# Strip version from `darwin###` # Strip version from `darwin###`
if(target_sys MATCHES "^darwin") if(target_sys MATCHES "^darwin")
set(target_sys "darwin") set(target_sys "darwin")
endif() endif()
set(${sys_var} ${target_sys} PARENT_SCOPE) set(${sys_var} ${target_sys} PARENT_SCOPE)
endfunction(get_arch_and_system_from_triple) endfunction(get_arch_and_system_from_triple)
# Query the default target triple of the compiler. execute_process(COMMAND ${CMAKE_CXX_COMPILER} -v
set(target_triple_option "-print-target-triple") RESULT_VARIABLE libc_compiler_info_result
if(CMAKE_COMPILER_IS_GNUCXX) OUTPUT_VARIABLE libc_compiler_info
# GCC does not support the "-print-target-triple" option but supports ERROR_VARIABLE libc_compiler_info)
# "-print-multiarch" which clang does not support for all targets. if(NOT (libc_compiler_info_result EQUAL "0"))
set(target_triple_option "-print-multiarch") message(FATAL_ERROR "libc build: error querying compiler info from the "
endif() "compiler: ${libc_compiler_info}")
execute_process(COMMAND ${CMAKE_CXX_COMPILER} ${target_triple_option} endif()
RESULT_VARIABLE libc_compiler_triple_check string(REGEX MATCH "Target: [-_a-z0-9]+[ \r\n]+"
OUTPUT_VARIABLE libc_compiler_triple) libc_compiler_target_info ${libc_compiler_info})
if(NOT (libc_compiler_triple_check EQUAL "0")) if(NOT libc_compiler_target_info)
message(FATAL_ERROR "libc build: error querying target triple from the " message(FATAL_ERROR "libc build: could not read compiler target info from:\n"
"compiler: ${libc_compiler_triple}") "${libc_compiler_info}")
endif() endif()
string(STRIP ${libc_compiler_target_info} libc_compiler_target_info)
string(SUBSTRING ${libc_compiler_target_info} 8 -1 libc_compiler_triple)
get_arch_and_system_from_triple(${libc_compiler_triple} get_arch_and_system_from_triple(${libc_compiler_triple}
compiler_arch compiler_sys) compiler_arch compiler_sys)
if(NOT compiler_arch) if(NOT compiler_arch)
message(FATAL_ERROR message(FATAL_ERROR
"libc build: Invalid or unknown libc compiler target triple: " "libc build: Invalid or unknown libc compiler target triple: "
"${libc_compiler_triple}") "${libc_compiler_triple}")
endif() endif()
▲ Show 20 Lines • Show All 86 Lines • Show Last 20 Lines