This is an archive of the discontinued LLVM Phabricator instance.

[MISched] Dump the execution trace of the schedule.
ClosedPublic

Authored by fpetrogalli on Jan 25 2023, 3:01 AM.

Details

Summary

The traces are printed only for bottom-up and top-down scheduling
because the values of TopReadyCycle and BottomReadyCycle are
inconsistent when obtained via bidirectional scheduling (see
BIDIRECTIONAL checks in the test).

Diff Detail

Event Timeline

fpetrogalli created this revision.Jan 25 2023, 3:01 AM
fpetrogalli requested review of this revision.Jan 25 2023, 3:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2023, 3:01 AM
thegameg added inline comments.Jan 25 2023, 9:27 AM
llvm/lib/CodeGen/MachineScheduler.cpp
955

BB->size()?

Address code review. NFC

fpetrogalli marked an inline comment as done.Jan 25 2023, 2:11 PM
thegameg accepted this revision.Jan 25 2023, 4:51 PM
thegameg added inline comments.
llvm/lib/CodeGen/MachineScheduler.cpp
1042

can we put the !SU -> continue path first to avoid the extra indent?

This revision is now accepted and ready to land.Jan 25 2023, 4:51 PM
fpetrogalli updated this revision to Diff 492359.EditedJan 26 2023, 1:48 AM

NFCI:

  1. Added continue if (!SU).
  2. Removed code I accidentally uploaded that was making pre-commit unhappy: https://reviews.llvm.org/harbormaster/unit/209975/ (well, OK this is an intended functional change... ;) )
fpetrogalli marked an inline comment as done.Jan 26 2023, 1:49 AM

Remove empty line from unrelated code. NFC

This revision was landed with ongoing or failed builds.Jan 26 2023, 8:55 AM
This revision was automatically updated to reflect the committed changes.