This is an archive of the discontinued LLVM Phabricator instance.

Differential D142494

[libc++][NFC] update Release Notes and Range Status for the completion of C++20 ranges
ClosedPublic

Authored by huixie90 on Jan 24 2023, 11:06 AM.

Details

Reviewers
ldionne
var-const
Group Reviewers
Restricted Project
Commits
rGc510c387631e: [libc++][NFC] update Range Status for the completion of C++20 ranges

Diff Detail

Event Timeline

huixie90 created this revision.Jan 24 2023, 11:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 11:06 AM
huixie90 requested review of this revision.Jan 24 2023, 11:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 11:06 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B209710: Diff 491856.Jan 24 2023, 1:25 PM
var-const accepted this revision as: var-const.Jan 24 2023, 2:08 PM

LGTM (I'll let @ldionne do the final approval).

ldionne accepted this revision.Jan 24 2023, 2:11 PM
This revision is now accepted and ready to land.Jan 24 2023, 2:11 PM
Mordante mentioned this in D142497: [libc++][ranges][NFC] Update Ranges status and release notes..Jan 25 2023, 9:31 AM
ldionne added a comment.Feb 10 2023, 11:08 AM

What's the status of this? Was it superseded?

huixie90 added a comment.Feb 11 2023, 7:13 AM
In D142494#4119108, @ldionne wrote:

What's the status of this? Was it superseded?

I am not totally sure now. I have we need to mention that join_view is experimental now?

var-const added a comment.Feb 13 2023, 6:27 PM
In D142494#4120335, @huixie90 wrote:
In D142494#4119108, @ldionne wrote:

What's the status of this? Was it superseded?

I am not totally sure now. I have we need to mention that join_view is experimental now?

@huixie90 Please feel free to submit this patch as is. I can do a follow-up in case anything needs updating.

This revision was landed with ongoing or failed builds.Feb 14 2023, 1:28 PM
Closed by commit rGc510c387631e: [libc++][NFC] update Range Status for the completion of C++20 ranges (authored by Hui). · Explain Why
This revision was automatically updated to reflect the committed changes.
Hui added a commit: rGc510c387631e: [libc++][NFC] update Range Status for the completion of C++20 ranges.

Revision Contents

PathSize
libcxx/
docs/
Status/
2 lines

Diff 497424

libcxx/docs/Status/RangesViews.csv

Standard,View,Assignee,CL,Status Standard,View,Assignee,CL,Status
C++20,`empty <https://wg21.link/P0896R4>`_,Zoe Carver,`D103208 <https://llvm.org/D103208>`_,✅ C++20,`empty <https://wg21.link/P0896R4>`_,Zoe Carver,`D103208 <https://llvm.org/D103208>`_,✅
C++20,`single <https://wg21.link/P0896R4>`_,Zoe Carver,`D106840 <https://llvm.org/D106840>`_,✅ C++20,`single <https://wg21.link/P0896R4>`_,Zoe Carver,`D106840 <https://llvm.org/D106840>`_,✅
C++20,`iota (view) <https://wg21.link/P0896R4>`_,Zoe Carver,`D107396 <https://llvm.org/D107396>`_,✅ C++20,`iota (view) <https://wg21.link/P0896R4>`_,Zoe Carver,`D107396 <https://llvm.org/D107396>`_,✅
C++20,`all <https://wg21.link/P0896R4>`_,Zoe Carver,`D102028 <https://llvm.org/D102028>`_,✅ C++20,`all <https://wg21.link/P0896R4>`_,Zoe Carver,`D102028 <https://llvm.org/D102028>`_,✅
C++20,`ref_view <https://wg21.link/P0896R4>`_,Zoe Carver,`D102020 <https://llvm.org/D102020>`_,✅ C++20,`ref_view <https://wg21.link/P0896R4>`_,Zoe Carver,`D102020 <https://llvm.org/D102020>`_,✅
C++20,`owning_view <https://wg21.link/P0896R4>`_,Arthur O'Dwyer,`D116894 <https://llvm.org/D116894>`_,✅ C++20,`owning_view <https://wg21.link/P0896R4>`_,Arthur O'Dwyer,`D116894 <https://llvm.org/D116894>`_,✅
C++20,`filter <https://wg21.link/P0896R4>`_,Louis Dionne,`D109086 <https://llvm.org/D109086>`_,✅ C++20,`filter <https://wg21.link/P0896R4>`_,Louis Dionne,`D109086 <https://llvm.org/D109086>`_,✅
C++20,`transform <https://wg21.link/P0896R4>`_,Zoe Carver,`D103056 <https://llvm.org/D103056>`_,✅ C++20,`transform <https://wg21.link/P0896R4>`_,Zoe Carver,`D103056 <https://llvm.org/D103056>`_,✅
C++20,`take <https://wg21.link/P0896R4>`_,Zoe Carver,`D106507 <https://llvm.org/D106507>`_,✅ C++20,`take <https://wg21.link/P0896R4>`_,Zoe Carver,`D106507 <https://llvm.org/D106507>`_,✅
C++20,`take_while <https://wg21.link/P1035R7>`_,Hui Xie,`D134952 <https://llvm.org/D134952>`_,✅ C++20,`take_while <https://wg21.link/P1035R7>`_,Hui Xie,`D134952 <https://llvm.org/D134952>`_,✅
C++20,`drop <https://wg21.link/P1035R7>`_,Zoe Carver,`D102037 <https://llvm.org/D102037>`_,✅ C++20,`drop <https://wg21.link/P1035R7>`_,Zoe Carver,`D102037 <https://llvm.org/D102037>`_,✅
C++20,`drop_while <https://wg21.link/P1035R7>`_,Hui Xie,`D135460 <https://llvm.org/D135460>`_,✅ C++20,`drop_while <https://wg21.link/P1035R7>`_,Hui Xie,`D135460 <https://llvm.org/D135460>`_,✅
C++20,`join <https://wg21.link/P0896R4>`_,Zoe Carver,`D107671 <https://llvm.org/D107671>`_,✅ C++20,`join <https://wg21.link/P0896R4>`_,Zoe Carver,`D107671 <https://llvm.org/D107671>`_,✅
C++20,`split <https://wg21.link/P2210R2>`_,Unassigned,No patch yet,Not started C++20,`split <https://wg21.link/P2210R2>`_,Hui Xie,`D142063 <https://llvm.org/D142063>`_,✅
C++20,`lazy_split <https://wg21.link/P0896R4>`_,Zoe Carver and Konstantin Varlamov,`D107500 <https://llvm.org/D107500>`_,✅ C++20,`lazy_split <https://wg21.link/P0896R4>`_,Zoe Carver and Konstantin Varlamov,`D107500 <https://llvm.org/D107500>`_,✅
C++20,`counted <https://wg21.link/P0896R4>`_,Zoe Carver,`D106923 <https://llvm.org/D106923>`_,✅ C++20,`counted <https://wg21.link/P0896R4>`_,Zoe Carver,`D106923 <https://llvm.org/D106923>`_,✅
C++20,`common <https://wg21.link/P0896R4>`_,Zoe Carver,`D105753 <https://llvm.org/D105753>`_,✅ C++20,`common <https://wg21.link/P0896R4>`_,Zoe Carver,`D105753 <https://llvm.org/D105753>`_,✅
C++20,`reverse <https://wg21.link/P0896R4>`_,Zoe Carver,`D107096 <https://llvm.org/D107096>`_,✅ C++20,`reverse <https://wg21.link/P0896R4>`_,Zoe Carver,`D107096 <https://llvm.org/D107096>`_,✅
C++20,`elements / keys / values <https://wg21.link/P1035R7>`_,Hui Xie,`D136268 <https://llvm.org/D136268>`_,✅ C++20,`elements / keys / values <https://wg21.link/P1035R7>`_,Hui Xie,`D136268 <https://llvm.org/D136268>`_,✅
C++20,`istream <https://wg21.link/P1035R7>`_,Hui Xie,`D133317 <https://llvm.org/D133317>`_,✅ C++20,`istream <https://wg21.link/P1035R7>`_,Hui Xie,`D133317 <https://llvm.org/D133317>`_,✅
,,,, ,,,,
,,,, ,,,,
Show All 14 Lines