This is an archive of the discontinued LLVM Phabricator instance.

update_test_checks.py: pick up --tool from UTC_ARGS
ClosedPublic

Authored by nhaehnle on Jan 24 2023, 3:47 AM.

Details

Summary

It's not clear to me how to write a test for this. The tests run in an
environment where the tools may not be in PATH, and so the existing
custom-tool.test needs to use --tool-binary when invoking
update_test_checks.py. But it can't do so without also using --tool.

This change does fix a problem though with using
update_any_test_checks.py in an environment where the tools *are*
available in PATH.

Diff Detail

Event Timeline

nhaehnle created this revision.Jan 24 2023, 3:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 3:47 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
nhaehnle requested review of this revision.Jan 24 2023, 3:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 24 2023, 3:47 AM
nikic accepted this revision.Jan 24 2023, 7:49 AM

LGTM

This revision is now accepted and ready to land.Jan 24 2023, 7:49 AM
arichardson accepted this revision.Jan 24 2023, 3:53 PM
This revision was automatically updated to reflect the committed changes.