[clang] Add test for CWG1111

[Endill]

Summary

Also mark CWG2385 as na, because it eliminates wording inconsistency introduced by CWG1111 resolution.

[erichkeane]

clang/test/CXX/drs/dr11xx.cpp

31

Can you also add the last example (with struct A) from the issue, and find a way to confirm that it is calling the right version?

clang/www/cxx_dr_status.html

6476

Were you able to track down which patch fixed this in clang 6?

I also don't think we can mark this as 'full' support, if its still broken in C++98. Unless we can find a good reason this wasn't/wont be done for C++98 as well, I don't know if we can mark this as 'done'.

[aaron.ballman]

clang/www/cxx_dr_status.html

6476

We can mark it as partial and put the reason in the details. I'm not certain if the python script has a way to do that easily or not.

[shafik]

clang/www/cxx_dr_status.html

6476

I think this might be related as well: https://github.com/llvm/llvm-project/issues/59910

[Endill]

clang/www/cxx_dr_status.html

6476

Were you able to track down which patch fixed this in clang 6?

I haven't even tried, since I don't intend to fix this for now.

We can mark it as partial and put the reason in the details.

Is false-positive warning enough to degrade full to partial despite the correct behavior? Just confirming here.

[erichkeane]

I didn't internalize that it was 'just a warning' (it was a -error in the test above), we should have a task for someone to remove that warning as it is no longer ambiguous. But I don't think it makes it 'partial' here anymore.

clang/test/CXX/drs/dr11xx.cpp

1

I see what happened now: Add -Wno-error=ambiguous-member-template to this line.

[Endill]

In D142315#4073782, @erichkeane wrote:

I didn't internalize that it was 'just a warning' (it was a -error in the test above), we should have a task for someone to remove that warning as it is no longer ambiguous. But I don't think it makes it 'partial' here anymore.

It is an error, because -pedantic-errors is enabled across DR test suite. I wonder why, given that even notes can't escape -verify mode unhandled.

[Endill]

clang/test/CXX/drs/dr11xx.cpp

31

Nice catch, thank you. Long exposure to P1787 makes one pay less attention to resolutions in CWG issues, it seems :)

[Endill]

Change status from "6" to "yes" since "ambiguous-member-template" warning is a false-positive now.

• Disable "ambiguous-member-template" diagnostic in 98 and 03 modes
• Add an example (struct A)
• Apply clang-format

[Endill]

clang/test/CXX/drs/dr11xx.cpp

1

Thank you for suggestion, but I'd like to avoid making changes that could affect other tests (now and in the future), so I went pragma way.

31

Done!

[Endill]

Move CWG2385 ("na") from D142316 into this patch. It makes more sense to put it here, because it fixes inconsistent wording introduced by CWG1111 resolution.

clang/test/CXX/drs/dr11xx.cpp

 // RUN: %clang_cc1 -std=c++98 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors
 // RUN: %clang_cc1 -std=c++11 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors
 // RUN: %clang_cc1 -std=c++14 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors
 // RUN: %clang_cc1 -std=c++17 %s -verify -fexceptions -fcxx-exceptions -pedantic-errors
 // RUN: %clang_cc1 -std=c++2a %s -verify -fexceptions -fcxx-exceptions -pedantic-errors
 
+namespace dr1111 { // dr1111: yes
+namespace example1 {
+template <typename> struct set;
+
+struct X {
+  template <typename T> void set(const T &value);
+};
+void foo() {
+  X x;
+#pragma clang diagnostic push
+#if __cplusplus < 201103L
+#pragma clang diagnostic ignored "-Wambiguous-member-template"
+#endif
+  x.set<double>(3.2);
+#pragma clang diagnostic pop
+}
+
+struct Y {};
+void bar() {
+  Y y;
+  y.set<double>(3.2); // expected-error {{no member named 'set' in 'dr1111::example1::Y'}}
+}
+} // namespace example1
+
+namespace example2 {
+struct A {};
+namespace N {
+struct A {
+  void g() {}
+  template <class T> operator T();
+};
+} // namespace N
+
+void baz() {
+  N::A a;
+  a.operator A();
+}
+} // namespace example2
+} // namespace dr1111
+
 namespace dr1113 { // dr1113: partial
   namespace named {
     extern int a; // expected-note {{previous}}
     static int a; // expected-error {{static declaration of 'a' follows non-static}}
   }
   namespace {
     extern int a;
     static int a; // ok, both declarations have internal linkage

clang/test/CXX/drs/dr23xx.cpp

void g() {
   f2(&b);
   f(C{});
   f(D{});
   f(F{}); // expected-error {{ambiguous conversion from derived class}}
 }
 } //namespace dr2303
 #endif
 
+// dr2385: na
+
 namespace dr2394 { // dr2394: 15
 
 struct A {};
 const A a;
 
 // Now allowed to default-init B.
 struct B { const A a; };
 B b;
 
 }

clang/www/cxx_dr_status.html

<tr id="1110">
     <td>NAD</td>
     <td>Incomplete return type should be allowed in <TT>decltype</TT> operand</td>
     <td class="none" align="center">Unknown</td>
   </tr>
   <tr id="1111">
     <td><a href="https://wg21.link/cwg1111">1111</a></td>
     <td>C++11</td>
     <td>Remove dual-scope lookup of member template names</td>
-    <td class="none" align="center">Unknown</td>
+    <td class="full" align="center">Yes</td>
   </tr>
   <tr id="1112">
     <td><a href="https://wg21.link/cwg1112">1112</a></td>
     <td>C++11</td>
     <td><TT>constexpr</TT> variables should have internal linkage like <TT>const</TT></td>
     <td class="none" align="center">Unknown</td>
   </tr>
   <tr id="1113">
<tr id="2384">
     <td>CD5</td>
     <td>Conversion function templates and qualification conversions</td>
     <td class="none" align="center">Unknown</td>
   </tr>
   <tr id="2385">
     <td><a href="https://wg21.link/cwg2385">2385</a></td>
     <td>CD5</td>
     <td>Lookup for <I>conversion-function-id</I>s</td>
-    <td class="none" align="center">Unknown</td>
+    <td class="na" align="center">N/A</td>
   </tr>
   <tr id="2386">
     <td><a href="https://wg21.link/cwg2386">2386</a></td>
     <td>CD5</td>
     <td><T>tuple_size</T> requirements for structured binding</td>
     <td class="full" align="center">Clang 9</td>
   </tr>
   <tr id="2387">