This is an archive of the discontinued LLVM Phabricator instance.

[Hexagon] Disallow using the same register for Vy/Vx in vdeal/vshuff
ClosedPublic

Authored by quic-akaryaki on Jan 20 2023, 1:09 PM.

Details

Summary

Non-assignment forms of vshuff and vdeal use the first two registers
(Vy, Vx) as both inputs and outputs. It is not valid to use the same
register for both Vy and Vx. The double-write error was not detected
previously because of a special case, which is not actually necessary.

Diff Detail

Unit TestsFailed

Event Timeline

quic-akaryaki created this revision.Jan 20 2023, 1:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 1:09 PM
Herald added a subscriber: hiraditya. · View Herald Transcript
quic-akaryaki requested review of this revision.Jan 20 2023, 1:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 1:09 PM
kparzysz accepted this revision.Jan 24 2023, 8:09 AM
This revision is now accepted and ready to land.Jan 24 2023, 8:09 AM
bcain accepted this revision.Jan 31 2023, 4:57 PM
This revision was landed with ongoing or failed builds.Feb 1 2023, 7:29 AM
This revision was automatically updated to reflect the committed changes.