[lldb/swig] Remove deprecated flags for generating bindings

[mib]

Summary

This patch conditionaly removes the -py3 swig flag that was used to
generate python3 bindings, since it's unsued since SWIG 4.1.0.

Deprecated command line option: -py3. Ignored, this option is no longer supported

This also removes the -shadow flag that have been deprecated since 2002.

Signed-off-by: Med Ismail Bennani <[e-mail]>

[JDevlieghere]

In what version of SWIG was this deprecated? We officially support SWIG 3 and later. What happens with SWIG 3 if you omit the flag, is it a NOOP? If so then this is fine, otherwise we should conditionalize it based on the SWIG version (or propose bumping the minimum to SWIG4). We should include this information in the commit message.

(Requesting changes because Dave already accepted it)

[kastiglione]

Looks like -py3 was marked deprecated and no-effect in 4.1.

[mib]

In D142245#4069960, @JDevlieghere wrote:

In what version of SWIG was this deprecated? We officially support SWIG 3 and later. What happens with SWIG 3 if you omit the flag, is it a NOOP? If so then this is fine, otherwise we should conditionalize it based on the SWIG version (or propose bumping the minimum to SWIG4). We should include this information in the commit message.

(Requesting changes because Dave already accepted it)

For now, I'll remove the flag conditionally.

[mib]

In D142245#4070002, @kastiglione wrote:

Looks like -py3 was marked deprecated and no-effect in 4.1.

Thanks for looking it up Dave :)

[kastiglione]

lldb/bindings/python/CMakeLists.txt

16–17

Note that -shadow has been deprecated since 2002 and is on by default.

[mib]

lldb/bindings/python/CMakeLists.txt

16–17

I guess that this is a leftover from the time we were support SWIG 1.x ... Since we bumped SWIG 3 as the minimal required version, I guess we could also get rid of the shadow flag (I checked the flag doesn't exist on Swig 3.0.12).

[mib]

Address @JDevlieghere & @kastiglione comments

[JDevlieghere]

LGTM

[kastiglione]

nice

lldb/bindings/python/CMakeLists.txt

+set(SWIG_EXTRA_FLAGS -c++ -threads -python)
+
+if ("${SWIG_VERSION}" VERSION_LESS "4.1.0")
+  set(SWIG_EXTRA_FLAGS ${SWIG_EXTRA_FLAGS} -py3)
+  message(STATUS "SWIG version ${SWIG_VERSION} uses `-py3` flag.")
+endif()
+
 add_custom_command(
   OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
   OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/lldb.py
   DEPENDS ${SWIG_SOURCES}
   DEPENDS ${SWIG_INTERFACES}
   DEPENDS ${SWIG_HEADERS}
   COMMAND ${SWIG_EXECUTABLE}
       ${SWIG_COMMON_FLAGS}
       -I${CMAKE_CURRENT_SOURCE_DIR}
-      -c++
-      -shadow
-      -python
-      -py3
-      -threads
+      ${SWIG_EXTRA_FLAGS}
       -outdir ${CMAKE_CURRENT_BINARY_DIR}
       -o ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp
       ${CMAKE_CURRENT_SOURCE_DIR}/python.swig
   VERBATIM
   COMMENT "Building LLDB Python wrapper")
 
 add_custom_target(swig_wrapper_python ALL DEPENDS
   ${CMAKE_CURRENT_BINARY_DIR}/LLDBWrapPython.cpp